-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing patterns book in Chinese (zh) #515
Conversation
* Added the Chinese translation of README template * Polish the translated README-template.md * Updated the README-template.md with reviewed comments
* Add the translation of service-vs-library * Updated the service-vs-library with review comments * Fixed the lint check error
* Committed the translation of core-team pattern * Updated the translation with comments * Updated the document accroding to the comments
* Added the new post of OpenSource Community Mentoring * Update the translation with comments * Update the translation according to the comments
* Added the translation of common-requirements * Updated the translation with review comments
* Added the translation of communication-tool * Updated the translation with review comments
* Added the translation of issue-tracker * Updated the translation with review comments * Fixed the markdown lint error
* Added the translation of dedicated community leader * Fixed the lint error of dedicated-community-leader.md * Updated the translation with review comments
* Added the translation of RFC * Updated the translation with comments
* Added the translation of innersource-portal * Updated the translation with suggestion of comments
* Updated the translation of contributing template * Updated the translation with comments
* Added the translation of repository-activity-score * Fixed the markdown lint error * Updated the translation with the review comments * Reverted wrong replace changes * Polished the code formate
* Update the translation of rfc-template * Updated the translation with review comments. * Fixed a typo
* Added the translation of review committee * Updated the translation with review comments
* Added the translation of crossteam project valuation * Updated the translation with the review comments
* Added the translation of praise participant * Fixed a markdownlint error of praise-participants * Updated the translation with review comments
* Added the translation of start as experiment * Update the translation with review comments * Update the translation with review comments
@WillemJiang all your latest changes are now integrated here. You can review them at: High-level this now all looks good to me but of course I don't speak Chinese so I cannot really review this :) Once you confirm this is all correct now, then I can merge this branch and get it published in our Production gitbook, so that the world can enjoy the InnerSource patterns in Chinese 🇨🇳 👍 |
@spier, thanks for your efforts in putting all the translation files together. I will go through the Chinese book to see if any obvious errors need to be fixed. |
* Added the translation and review date * Writing updated files for the book Co-authored-by: WillemJiang <WillemJiang@users.noreply.github.com>
@WillemJiang looks good. All merged now. Once you reviewed everything, could you leave an approval review on this PR? |
* Added the translation and review date * Clean up the Chinese translation patterns * Fixed the formate error of RFC pattern Co-authored-by: WillemJiang <WillemJiang@users.noreply.github.com>
@WillemJiang thank you! All merged. Two questions:
|
Yes, it's hard to find the right word in Chinese for the "Trusted Committer", so we keep using the English term.
You can find more information about the review information here. BTW, Big +1 for us to build a common translation process. |
Got it. So the reviews happen as conversations on the PRs of your fork. Do you have a list of contributors that we should attribute this translation work to? Then we could mention them once we merge this branch, so that they get properly acknowledged in the contributor chart on our main repo. |
Yeah, it's a great idea, I can add a comment with all the contributors in this PR. |
* Fixed the formate issue of the Chinese translations Co-authored-by: WillemJiang <WillemJiang@users.noreply.github.com>
Great. I think we can use this syntax, for which we only need the GitHub user name.
This is just a guess though, as I did not find this exact syntax explained in the GitHub docs. |
It was added by github action which just generates the TOC, can we just ignore it? |
Thanks for the contributions from
|
Excellent. Committing this as:
Finger's crossed that it works and you all get your credits in the contribution graph! :) |
@WillemJiang looks like the attribution worked as expected: |
@WillemJiang @hncslwx @sunzhh02 @gzchenyong @tanzhongyi003 @anzipomelo your Chinese translation of the InnerSource patterns are now live at: patterns.innersourcecommons.org/v/zh/ Would be great to advertise this broadly in the Chinese-speaking InnerSource community :) Fantastic work. You should be really proud of what you achieved here! |
Combining the existing work done in #513 and #514.