Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing patterns book in Chinese (zh) #515

Merged
merged 67 commits into from
Jan 4, 2023
Merged

Publishing patterns book in Chinese (zh) #515

merged 67 commits into from
Jan 4, 2023

Conversation

spier
Copy link
Member

@spier spier commented Dec 29, 2022

Combining the existing work done in #513 and #514.

* Added the Chinese translation of README template

* Polish the translated README-template.md

* Updated the README-template.md with reviewed comments
* Add the translation of service-vs-library

* Updated the service-vs-library with review comments

* Fixed the lint check error
* Committed the translation of core-team pattern

* Updated the translation with comments

* Updated the document accroding to the comments
* Added the new post of OpenSource Community Mentoring

* Update the translation with comments

* Update the translation according to the comments
* Added the translation of common-requirements

* Updated the translation with review comments
* Added the translation of communication-tool

* Updated the translation with review comments
* Added the translation of issue-tracker

* Updated the translation with review comments

* Fixed the markdown lint error
* Added the translation of dedicated community leader

* Fixed the lint error of dedicated-community-leader.md

* Updated the translation with review comments
* Added the translation of RFC

* Updated the translation with comments
* Added the translation of innersource-portal

* Updated the translation with suggestion of comments
* Updated the translation of contributing template

* Updated the translation with comments
* Added the translation of repository-activity-score

* Fixed the markdown lint error

* Updated the translation with the review comments

* Reverted wrong replace changes

* Polished the code formate
* Update the translation of rfc-template

* Updated the translation with review comments.

* Fixed a typo
* Added the translation of review committee

* Updated the translation with review comments
* Added the translation of crossteam project valuation

* Updated the translation with the review comments
* Added the translation of praise participant

* Fixed a markdownlint error of praise-participants

* Updated the translation with review comments
* Added the translation of start as experiment

* Update the translation with review comments

* Update the translation with review comments
@spier spier self-assigned this Jan 1, 2023
@spier
Copy link
Member Author

spier commented Jan 1, 2023

@WillemJiang all your latest changes are now integrated here. You can review them at:
https://innersourcecommons.gitbook.io/innersource-patterns-staging/v/zh-test/

High-level this now all looks good to me but of course I don't speak Chinese so I cannot really review this :)

Once you confirm this is all correct now, then I can merge this branch and get it published in our Production gitbook, so that the world can enjoy the InnerSource patterns in Chinese 🇨🇳 👍

@spier spier marked this pull request as ready for review January 1, 2023 14:11
@WillemJiang
Copy link
Collaborator

https://innersourcecommons.gitbook.io/innersource-patterns-staging/v/zh-test/

@spier, thanks for your efforts in putting all the translation files together. I will go through the Chinese book to see if any obvious errors need to be fixed.

@WillemJiang
Copy link
Collaborator

@spier I just sent a PR #516 for it.

* Added the translation and review date
* Writing updated files for the book

Co-authored-by: WillemJiang <WillemJiang@users.noreply.github.com>
@spier
Copy link
Member Author

spier commented Jan 3, 2023

@WillemJiang looks good. All merged now.

Once you reviewed everything, could you leave an approval review on this PR?

@WillemJiang
Copy link
Collaborator

@spier I created another PR #517 to fix some minor typos I found recently.

* Added the translation and review date
* Clean up the Chinese translation patterns
* Fixed the formate error of RFC pattern

Co-authored-by: WillemJiang <WillemJiang@users.noreply.github.com>
@spier
Copy link
Member Author

spier commented Jan 3, 2023

@WillemJiang thank you! All merged.

Two questions:

  1. I noticed that you kept "Trusted Committer" in English, maybe because it is a specific InnerSource term that would be difficult to translate?
  2. Wonder how you and @hncslwx did the review process, as it looks like you did this outside of GitHub? Just curious about this to see if there is something that we can learn from this for future translations in other languages.

@WillemJiang
Copy link
Collaborator

@WillemJiang thank you! All merged.

Two questions:

  1. I noticed that you kept "Trusted Committer" in English, maybe because it is a specific InnerSource term that would be difficult to translate?

Yes, it's hard to find the right word in Chinese for the "Trusted Committer", so we keep using the English term.

  1. Wonder how you and @hncslwx did the review process, as it looks like you did this outside of GitHub? Just curious about this to see if there is something that we can learn from this for future translations in other languages.

You can find more information about the review information here.

BTW, Big +1 for us to build a common translation process.

@spier
Copy link
Member Author

spier commented Jan 4, 2023

Got it. So the reviews happen as conversations on the PRs of your fork.

Do you have a list of contributors that we should attribute this translation work to? Then we could mention them once we merge this branch, so that they get properly acknowledged in the contributor chart on our main repo.

@WillemJiang
Copy link
Collaborator

Got it. So the reviews happen as conversations on the PRs of your fork.

Do you have a list of contributors that we should attribute this translation work to? Then we could mention them once we merge this branch, so that they get properly acknowledged in the contributor chart on our main repo.

Yeah, it's a great idea, I can add a comment with all the contributors in this PR.

@InnerSourceCommons InnerSourceCommons deleted a comment from WillemJiang Jan 4, 2023
* Fixed the formate issue of the Chinese translations

Co-authored-by: WillemJiang <WillemJiang@users.noreply.github.com>
@spier
Copy link
Member Author

spier commented Jan 4, 2023

Great.

I think we can use this syntax, for which we only need the GitHub user name.

Co-authored-by: WillemJiang WillemJiang@users.noreply.github.com

This is just a guess though, as I did not find this exact syntax explained in the GitHub docs.

@WillemJiang
Copy link
Collaborator

Great.

I think we can use this syntax, for which we only need the GitHub user name.

Co-authored-by: WillemJiang WillemJiang@users.noreply.github.com

This is just a guess though, as I did not find this exact syntax explained in the GitHub docs.

It was added by github action which just generates the TOC, can we just ignore it?

@WillemJiang
Copy link
Collaborator

Thanks for the contributions from

[姜宁 Willem Jiang]:(https://github.com/willemjiang)
[龙文选 Wenxuan Long]:(https://github.com/hncslwx)
[孙振华 Zhenhua Sun](https://github.com/sunzhh02)
[陈泳 Yong Chen](https://github.com/gzchenyong)
[谭中意 Jerry Tan](https://github.com/tanzhongyi003)
[安旭 Xu An](https://github.com/anzipomelo)

@spier
Copy link
Member Author

spier commented Jan 4, 2023

Excellent. Committing this as:

Co-authored-by: Willem Jiang <WillemJiang@users.noreply.github.com>
Co-authored-by: Wenxuan Long <hncslwx@users.noreply.github.com>
Co-authored-by: Zhenhua Sun <sunzhh02@users.noreply.github.com>
Co-authored-by: Yong Chen <gzchenyong@users.noreply.github.com>
Co-authored-by: Jerry Tan <tanzhongyi003@users.noreply.github.com>
Co-authored-by: Xu An <anzipomelo@users.noreply.github.com>

Finger's crossed that it works and you all get your credits in the contribution graph! :)

@spier spier merged commit 0ebc0bd into main Jan 4, 2023
@spier spier deleted the book-zh branch January 4, 2023 19:46
@spier
Copy link
Member Author

spier commented Jan 4, 2023

@WillemJiang looks like the attribution worked as expected:

Screenshot 2023-01-04 at 20 49 10

@spier
Copy link
Member Author

spier commented Jan 4, 2023

@WillemJiang @hncslwx @sunzhh02 @gzchenyong @tanzhongyi003 @anzipomelo your Chinese translation of the InnerSource patterns are now live at: patterns.innersourcecommons.org/v/zh/

Would be great to advertise this broadly in the Chinese-speaking InnerSource community :)

Fantastic work. You should be really proud of what you achieved here!
I will also send some shout outs to all of you in Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type - Translation Translating patterns into other languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants