Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concept Anchor - Formal pattern improvements #530

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Concept Anchor - Formal pattern improvements #530

merged 2 commits into from
Mar 10, 2023

Conversation

fioddor
Copy link
Contributor

@fioddor fioddor commented Mar 9, 2023

  • Move pattern status to its section
  • Fill in the resulting context

@fioddor
Formal pattern improvements
325f659 
- Move pattern status to its section
- Fill in the resulting context
@spier spier changed the title Formal pattern improvements Concept Anchor - Formal pattern improvements Mar 9, 2023
@spier spier added 1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR labels Mar 9, 2023
spier
spier reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the incremental approach you are taking to improving the patterns!
Left some comments inline.

patterns/1-initial/concept-anchor.md Outdated Show resolved Hide resolved
patterns/1-initial/concept-anchor.md Outdated Show resolved Hide resolved
patterns/1-initial/concept-anchor.md Outdated Show resolved Hide resolved
@fioddor @spier
Fix wording
bca3053 
Several wording and style fixes.

Co-authored-by: Sebastian Spier <github@spier.hu>
@fioddor
Copy link
Contributor Author

fioddor commented Mar 10, 2023

Thanks for your review, @spier. I'm discovering that I'm multitasking too much. You are catching embarrasing obvious flaws that slip through my context juggling.

spier
spier reviewed Mar 10, 2023
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spier spier merged commit 73499ff into InnerSourceCommons:main Mar 10, 2023
@spier
Copy link
Member

spier commented Mar 10, 2023

Thanks for your review, @spier. I'm discovering that I'm multitasking too much. You are catching embarrasing obvious flaws that slip through my context juggling.

Hehe no worries @fioddor.

Thanks again for your contributions here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spier spier spier approved these changes

@lenucksi lenucksi Awaiting requested review from lenucksi lenucksi is a code owner

@NewMexicoKid NewMexicoKid Awaiting requested review from NewMexicoKid NewMexicoKid is a code owner

@cewilliams cewilliams Awaiting requested review from cewilliams cewilliams is a code owner

@robtuley robtuley Awaiting requested review from robtuley robtuley is a code owner

Assignees
No one assigned
Labels
1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fioddor @spier