Review GHA for i18n consistency check #551
Conversation
spier
changed the title
| @@ -79,6 +80,7 @@ jobs: | |||
| fi | |||
| done | |||
| - name: Create Issue | |||
| if: ${{ <expression> }} | |||
There was a problem hiding this comment.
This is not working as is.
However i was wondering if here we could test for the existence of issue.md and only run this entire step if that file exists?
There was a problem hiding this comment.
That implementation should be in place below, but it doesn't seem to be working.
If there were a similar issue, it would update the new edits as a comment to that issue, so that a new issue would not be created.
Also, since the script is doing the checking for the issue's existence here, there should be an Action in the previous section to make that determination. The process would be like splitting the existing code.
if expr "$existing_issue_id" : '^[0-9]*$' >/dev/null; then
gh issue comment "$existing_issue_id" -F issue.md -R $GITHUB_REPOSITORY
else
gh issue create -t "$issue_title" -F issue.md -R $GITHUB_REPOSITORY -l documentation
fi
|
Sorry for being late to reply. I'm starting to review now! Thank you for your PR! |
…y again * Refactor code * FIx bugs * Update token * Update scripts * Small fix
|
@spier Please check my update on this So far, it has worked properly.
Here's sample |
| # Get the translated file name and check if it exists | ||
| i18n_filename=$(echo "$file" | sed 's/patterns\/2-structured/translation\/${{matrix.language}}\/patterns/g') | ||
| # Declare the flags | ||
| declare -A flags=( ["ja"]=":jp: Japanese" ["zh"]=":cn: Chinese") |
There was a problem hiding this comment.
Where to lookup the icons to use here?
| content_header=$(echo "$(cat "$file")" | grep -E '^title+' | sort -r | head -n1) | ||
|
|
||
| if [[ $((original_updated_at - i18n_content_updated_at)) -ge 1 ]]; then | ||
| content_header=$(grep -E '^title+' "$file" | sort -r | head -n1) |
There was a problem hiding this comment.
Doesn't look like the title extract works right now
However let's leave this in here, as we may be adding a frontmatter to all patterns anyways, at which point this should work :)
There was a problem hiding this comment.
No wonder this thing doesn't work.
I was getting the title from the "title: foobar" meta info to match hugo's md style... But this time it's gitbook, so I need to extract from ## Title.
I didn't realize this when I ported...
I've changed it to use awk to extract it, so it should work now!
|
Thank you for the addition, will comment on it soon...! |
LGTM! thanks Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
LGTM! Co-authored-by: Sebastian Spier <github@spier.hu>
|
Thank you for working on this @yuhattor! Please approve the PR when it looks good to go from your side. |
|
Thank you! After some aditions... Now I confirmed that it works properly. Thank you @spier for the contribution!! |
This PR is making minor cosmetic modifications to the new GHA that checks the consistency of the translations.
See file:
.github/workflows/i18n-consistency-checker.yamlMain purpose of this PR is for me to understand what the GHA does, and to allow me to ask question to @yuhattor (who created this GHA). That way we have some written documentation that others can refer to later.