Fix URLs of images used by the WelcomeBot #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spier
requested review from
lenucksi,
NewMexicoKid,
cewilliams,
robtuley and
yuhattor
as code owners
|
While I don't know how this issue was caused, I can confirm that the new URLs are working. :) Therefore I am merging this, so that the WelcomeBot will at least add working images to new issues/PRs created by first-time contributors. |
spier
added
Type - Maintenance / Cleanup
rmarting
pushed a commit
to rmarting/InnerSourcePatterns
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The WelcomeBot that we are using in this repo is using 3 different images to thank new contributors.
I noticed that the images stopped working, as evident in this example:
I don't know why the old image URLs stopped working.
It might have to do with API changes that were zenodo launched on Oct 13th but that is just a hunch:
https://help.zenodo.org/docs/about/whats-changed/
https://blog.zenodo.org/2022/12/07/2022-12-07-zenodo-on-inveniordm/
zenodo says that their changes should not contain any breaking changes but who knows, maybe this was an unintended side-effect?
As an aside: I tried to find a zenodo Support channel where I can report this issue but could not find an appropriate one sof ar.
List of changes proposed in this PR (pull-request)