Good Governance Initiative (GGI) #40

fioddor · 2023-10-12T18:25:28Z

Helps: InnerSourceCommons/ispo-working-group#40

The ISPO-WG suggested to include a governance section.
I've created a draft for review. I haven't yet linked this page from the TOC.

governance/governance.md

rrrutledge

Just a few changes? Almost ready 🎉 !

governance/governance.md

Co-authored-by: rrrutledge <rrrutledge@users.noreply.github.com>

This is meant to be printed on paper, where hyperlinks don't work.

Co-authored-by: Sebastian Spier <github@spier.hu>

The reasons for fostering usage were mentioned but their relation to the topic may not have been clear.

spier

Great work @fioddor!

I don't have enough content to assess if the content is fit for purpose.
Therefore I kept my review focused on structure, formatting, etc

A couple of changes that I pushed myself:

updated this PR with the latest content from the main branch
also ran the spell/style checks on the content (see inline annotations)
included the governance file to the ToC in SUMMARY.md, so that it will get included in the book (once we merge this branch)

See other comments inline.

governance/governance.md

spier · 2023-10-29T17:57:55Z

governance/governance.md

+[^1]: http://oss-watch.ac.uk/resources/governancemodels
+
+[^2]: https://ospo-alliance.org/ggi/
+
+[^3]: https://github.com/InnerSourceCommons/InnerSourcePatterns
+
+[^4]: https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/patterns/1-initial/introducing-metrics-in-innersource.md
+
+[^5]: https://innersourcecommons.org/
+
+[^6]: https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/patterns/1-initial/code-consumers.md
+
+[^7]: https://ospo-alliance.org/ggi/activities/open_source_procurement_policy/


Do we have to link via footnotes, or could we add links to the content directly?
Personally I would find it easier to use the links if they were included in the content directly.

That's because you read it on a device. But this was meant to be a book with copies printed on paper, where hyperlinks don't work.

I've seen other pages (like the introduction/framework or the infrastructure chapter) providing clickable inline links, but most of the introduction chapter seems to go for footnotes, so I don't know.

... this was meant to be a book with copies printed on paper, where hyperlinks don't work.

That is interesting. Is this information captured in writing somewhere, or information you got through the bitergia connection? ❤️

Also @rrrutledge what's your take on this?

Assuming that our current goal here is to publish an online book (and not a printed book), my preference would be to go for regular hyperlinks, rather than footnotes.

However for the moment it does not matter much either way. We can also leave them as footnotes for now and decide later what we want to do with them.

governance/governance.md

spier · 2023-10-29T18:22:09Z

@fioddor one more question:
Is your content in this PR an extension of what is already included in the book here?

fioddor · 2023-10-29T20:25:44Z

@fioddor one more question: Is your content in this PR an extension of what is already included in the book here?

Yes.

Co-authored-by: Sebastian Spier <github@spier.hu>

fioddor · 2023-10-29T21:43:09Z

Great work @fioddor!

Great review too, @spier. Thanks for automating the spell check. I was leaving the rebase and the TOC for the end but I guess this is already maturing and although the TOC is prone to conflicts, these should be clear to handle! :-)

spier · 2023-10-29T22:24:00Z

@fioddor one more question: Is your content in this PR an extension of what is already included in the book here?

Yes.

Got it.

How to integrate the new content into that existing page?
Do you have any thoughts or preferences with regards to that?

As a simple integration one could link from Framework/Governance to this more detailed new page about Governance.
Although that does not seem like a fully coherent solution.

rrrutledge · 2023-11-01T19:43:34Z

How to integrate the new content into that existing page?

It would be good for them to relate in some holistic way. Minimum linking between them so they acknowledge each other.

rrrutledge · 2023-11-06T16:57:38Z

@akritiko will have a look as well!

rrrutledge

Very valuable!

governance/governance.md

rrrutledge · 2023-11-14T22:01:43Z

governance/governance.md

+
+Dependency management needs to take care of both:
+ - Internal InnerSource dependencies
+ - Dependencies on privative software and services (usually


What do you mean by privative? I don't understand (even after looking up the word).

Oops. This is a false friend: In spanish, privativo is a stronger variant of private, a way to refer to propietary software stressing the fact that it deprives its users of certain rights.

Words like propietary and property stress ownership (control by the owner) while private stresses deprivation (for others).

Would private software work in english?

Ah, no problem! We’ll figure out the right wording! What would be the difference “proprietary software” and “internal InnerSource software”?

stressing the fact that it deprives its users of certain rights.

Restricted?

Co-authored-by: rrrutledge <rrrutledge@users.noreply.github.com>

jeffabailey · 2024-01-02T19:25:55Z

@fioddor

Do you have time to follow up on this PR?

It looks like it needs a few changes and may make it over the finish line soon.

If no, I recommend we merge this PR and do further cleanup based on requested changes in another PR.

Any objections?

rrrutledge · 2024-01-15T16:06:39Z

Sounds great, @jeffabailey

Since this branch is currently abandoned, I'm merging this in and we can finish the work to better integrate the content in a follow-up PR.

Create governance.md

a905096

fioddor mentioned this pull request Oct 12, 2023

Good InnerSource Governance (map against GGI) InnerSourceCommons/ispo-working-group#40

Open

jeffabailey reviewed Oct 12, 2023

View reviewed changes

governance/governance.md Show resolved Hide resolved

jeffabailey reviewed Oct 12, 2023

View reviewed changes

governance/governance.md Outdated Show resolved Hide resolved

Minor fix

e23366c

spier reviewed Oct 21, 2023

View reviewed changes

governance/governance.md Outdated Show resolved Hide resolved

spier added the enhancement label Oct 21, 2023

rrrutledge requested changes Oct 27, 2023

View reviewed changes

fioddor commented Oct 29, 2023

View reviewed changes

governance/governance.md Outdated Show resolved Hide resolved

fioddor and others added 2 commits October 29, 2023 13:33

Apply suggestions from code review

91ee7ca

Co-authored-by: rrrutledge <rrrutledge@users.noreply.github.com>

Add link as suggeted

fc10671

fioddor requested a review from a team as a code owner October 29, 2023 12:39

fioddor and others added 6 commits October 29, 2023 13:55

Re-style the links for a book

aa78409

This is meant to be printed on paper, where hyperlinks don't work.

Apply suggestion

b044c0e

Co-authored-by: Sebastian Spier <github@spier.hu>

Clarify the initial comments of a section

85002d5

The reasons for fostering usage were mentioned but their relation to the topic may not have been clear.

Merge remote-tracking branch 'origin/main' into governance

982167c

Include governance doc in spell check

c635fcc

Include new Governance chapter in the book (by adding it to the ToC)

75445dc

spier previously requested changes Oct 29, 2023

View reviewed changes

spier added 3 commits October 29, 2023 19:02

Removing double newline

6a4eac5

Removing double newline

c0e31e3

Remove whitespace

2adfafc

Apply suggestions from code review

15f50db

Co-authored-by: Sebastian Spier <github@spier.hu>

jeffabailey approved these changes Oct 31, 2023

View reviewed changes

rrrutledge requested a review from akritiko November 6, 2023 16:57

rrrutledge approved these changes Nov 14, 2023

View reviewed changes

Fix typo

9898430

Co-authored-by: rrrutledge <rrrutledge@users.noreply.github.com>

dellagustin-sap assigned jeffabailey Dec 4, 2023

Merge branch 'main' into governance

91594b8

jeffabailey merged commit d4b0771 into InnerSourceCommons:main Jan 25, 2024
1 check passed

jeffabailey mentioned this pull request Jan 25, 2024

Refactor governance content #69

Draft

fioddor deleted the governance branch April 8, 2024 15:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Good Governance Initiative (GGI) #40

Good Governance Initiative (GGI) #40

fioddor commented Oct 12, 2023

rrrutledge left a comment

spier left a comment

spier Oct 29, 2023

fioddor Oct 29, 2023

spier Oct 29, 2023

spier commented Oct 29, 2023

fioddor commented Oct 29, 2023

fioddor commented Oct 29, 2023

spier commented Oct 29, 2023

rrrutledge commented Nov 1, 2023

rrrutledge commented Nov 6, 2023

rrrutledge left a comment

rrrutledge Nov 14, 2023

fioddor Nov 15, 2023

rrrutledge Nov 17, 2023

jeffabailey Nov 17, 2023

jeffabailey commented Jan 2, 2024

rrrutledge commented Jan 15, 2024

Good Governance Initiative (GGI) #40

Good Governance Initiative (GGI) #40

Conversation

fioddor commented Oct 12, 2023

rrrutledge left a comment

Choose a reason for hiding this comment

spier left a comment

Choose a reason for hiding this comment

spier Oct 29, 2023

Choose a reason for hiding this comment

fioddor Oct 29, 2023

Choose a reason for hiding this comment

spier Oct 29, 2023

Choose a reason for hiding this comment

spier commented Oct 29, 2023

fioddor commented Oct 29, 2023

fioddor commented Oct 29, 2023

spier commented Oct 29, 2023

rrrutledge commented Nov 1, 2023

rrrutledge commented Nov 6, 2023

rrrutledge left a comment

Choose a reason for hiding this comment

rrrutledge Nov 14, 2023

Choose a reason for hiding this comment

fioddor Nov 15, 2023

Choose a reason for hiding this comment

rrrutledge Nov 17, 2023

Choose a reason for hiding this comment

jeffabailey Nov 17, 2023

Choose a reason for hiding this comment

jeffabailey commented Jan 2, 2024

rrrutledge commented Jan 15, 2024