Enabling Express Login #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a gif explaining how it works(in my app I did that if User is opening the app and unlogged i will try to log him with expressLogin, if he is unlogging i will not)
|
|
Hey! Sorry for the late answer. I'm pretty busy right now, but I'll take a look. |
|
@greymag had the chance to take a look? |
|
We are using in a 10M MAU in production and everything is great with no errors being reported. |
|
Hey! I apologize for that delay, I'll merge your PR by the end of the week |
greymag
reviewed
Nov 1, 2020
android/src/main/java/ru/innim/flutter_login_facebook/MethodCallHandler.java
Outdated
Show resolved
Hide resolved
|
@greymag applied changes |
greymag
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is a non-breaking change.
Just giving developers the chance to authenticate the user automatically if user already was logged into the app.
Just call
FacebookLogin().expressLogin()and it will return aFacebookLoginResultjust like it does when user clicks the button.Android only for now (It depends on Facebook's iOS SDK), on iOS i've made it so it always returns "cancel" instead of "error" or "not implemented" but IMHO Users should have a logic inside their app to use it only on Android.
Documentation:
https://developers.facebook.com/docs/facebook-login/android/#expresslogin