Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isClear for singleDatePicker #296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix isClear for singleDatePicker #296

wants to merge 1 commit into from

Commits on Feb 21, 2022

  1. Fix isClear for singleDatePicker 

    Inside isClear computed property, don't check if endDate is set when using singleDatePicker.
Without this fix, the dateRange.startDate does not properly set this.start data property.

To reproduce the issue, programmatically toggle the picker with singleDatePicker and initial property without endDate set. 
You will see that the passed in startDate date and time are not selected in the popup.
To verify this issue, if you set the endDate to new Date(), then date and time are properly selected on picker toggle.
    @tkrevh
    tkrevh committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    da1d82d View commit details
    Browse the repository at this point in the history