Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of upload profile image #348

Open
shilpashingnapure opened this issue May 17, 2024 · 30 comments
Open

Enhancement of upload profile image #348

shilpashingnapure opened this issue May 17, 2024 · 30 comments
Assignees
Labels
gssoc Girl Script Summer of Code level3 45 points

Comments

@shilpashingnapure
Copy link
Contributor

  1. refer this issue Add Option to Upload Profile Picture #243
  2. Adding the upload profile image at time of registrations for both user
Copy link

Hi there! Thanks for opening this issue. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

@shilpashingnapure
Copy link
Contributor Author

shilpashingnapure commented May 17, 2024

@codewarnab or @rishicds can you please add label for this issue and assign this to me.

@rishicds rishicds added level3 45 points gssoc Girl Script Summer of Code labels May 17, 2024
@rishicds
Copy link
Collaborator

Best of luck @shilpashingnapure

@codewarnab
Copy link
Collaborator

@shilpashingnapure are you planning to add it in the registration page itself ?
i think it will be better if we ask the user immediately after the registartion we need to keep as much simple as possible

@codewarnab
Copy link
Collaborator

also try to make the profile picture is an optional thing probably adding a random avtar would be enough and user can change it if they want

@shilpashingnapure
Copy link
Contributor Author

@shilpashingnapure are you planning to add it in the registration page itself ? i think it will be better if we ask the user immediately after the registration we need to keep as much simple as possible

I don't get it this. you mean once registration is done after that we have ask user if you want to upload profile pic or not like this ?

@shilpashingnapure
Copy link
Contributor Author

shilpashingnapure commented May 17, 2024

I guess this feature will get complicate then , for simplicity then we can just keep upload photo option for profile page only and also we are already showing default image to users in profile page so i think we don't need to add this what you think guys ?

@codewarnab
Copy link
Collaborator

@shilpashingnapure are you planning to add it in the registration page itself ? i think it will be better if we ask the user immediately after the registration we need to keep as much simple as possible

I don't get it this. you mean once registration is done after that we have ask user if you want to upload profile pic or not like this ?
yes

@codewarnab
Copy link
Collaborator

I guess this feature will get complicate then , for simplicity then we can just keep upload photo option for profile page only and also we are already showing default image to users in profile page so i think we don't need to add this what you think guys ?

yeah it might be get complicated . but our main priority is the easiest possible reporting and if any user want to register it should be super simple

i think showing a modal if they want to upload profile picture or not would be good then create a uploading section their or just redirect to profile page and show a tooltip for uplloading profile picture .

let me know what are your thoughts on this

@shilpashingnapure
Copy link
Contributor Author

this will be good idea , after registration we can redirect to profile page and show a tooltip for uploading

@codewarnab
Copy link
Collaborator

this will be good idea , after registration we can redirect to profile page and show a tooltip for uploading

as it is complicated task it is better to break it in multiple issues . you can do it else i will do it tonight

@shilpashingnapure
Copy link
Contributor Author

now we are redirecting to the page , so i think we no need of multiple issues , we can do this in single task only.

@Tani1126
Copy link

pls, assign this issue to me, i am a contributor at GSSOC'24.

@codewarnab
Copy link
Collaborator

@shilpashingnapure hey i was just checking the paws you have added the profile picture functionality before why is the feature is coming when i click on the profile icon in profile page ?

@codewarnab
Copy link
Collaborator

@rishicds have you updated the deployed branch ?

@rishicds
Copy link
Collaborator

yes @codewarnab , check in a few mins

@shilpashingnapure
Copy link
Contributor Author

@shilpashingnapure hey i was just checking the paws you have added the profile picture functionality before why is the feature is coming when i click on the profile icon in profile page ?
can you show me in video.. so i get clear what happened

@codewarnab
Copy link
Collaborator

@shilpashingnapure hey i was just checking the paws you have added the profile picture functionality before why is the feature is coming when i click on the profile icon in profile page ?
can you show me in video.. so i get clear what happened

nope its working fine

@codewarnab
Copy link
Collaborator

now we are redirecting to the page , so i think we no need of multiple issues , we can do this in single task only.

yeah but after registration you need show a modal that if user wants to upload profile pic or not if not then dont redirect else redirect it will not much hard as already their are two modals in the app you can just take the code from their so if you wan this work under one issue feel free to start working on it also we have updated the deployed branch you can test the profile picture functionality properly if you find any bugs

@shilpashingnapure
Copy link
Contributor Author

okay , I will look into this

@shilpashingnapure
Copy link
Contributor Author

shilpashingnapure commented May 23, 2024

@codewarnab @rishicds Hi , can you assign me and label for this close PR #344
other wise , my point will not get count. (don't know now it will counted or not , but still if possible can you assign me).
actually today I got mail , in there its mention in PR also need to be assigned and label.

and for backend PR which merged it will not get counted now 🤔 , can you tell me if you know anything about this ?

@rishicds
Copy link
Collaborator

@shilpashingnapure that pr and issue from backend repository will be transferred here and will be assigned the appropriate labels, then it will be counted :)

@rishicds rishicds reopened this May 23, 2024
@shilpashingnapure
Copy link
Contributor Author

@shilpashingnapure that pr and issue from backend repository will be transferred here and will be assigned the appropriate labels, then it will be counted :)

for this two backend PR which merged , if possible can you assign Innovateninjas/Paws-Backend#11 , Innovateninjas/Paws-Backend#10

And Thank You so Much for clearing my doubt 😊.

@shilpashingnapure
Copy link
Contributor Author

@codewarnab for this backend issue , you only added gssoc label , points label is not added , does it will count 😅?

@codewarnab
Copy link
Collaborator

@codewarnab for this backend issue , you only added gssoc label , points label is not added , does it will count 😅?

done added point label . do not worry you will get points for all of your contribution 😊

@shilpashingnapure
Copy link
Contributor Author

@codewarnab hi can you suggest me does this flow make sense ?
for redirect I used URL with query params
and when we click on skip it will redirect to home page

video1108293007.mp4

@codewarnab
Copy link
Collaborator

@codewarnab hi can you suggest me does this flow make sense ? for redirect I used URL with query params and when we click on skip it will redirect to home page

video1108293007.mp4

Yes looking perfect

@shilpashingnapure
Copy link
Contributor Author

@codewarnab Hey , today I tested the upload feature , but now its not working then i got to know in backend has some changes.
In frontend I need to fixed this , for this I have to created new issue right?
and also when i see in backend its have profile update info , so we have to update profile info also ( like name and phone number) ?
because in frontend we are only able to update profile photo only.

@codewarnab
Copy link
Collaborator

codewarnab commented May 26, 2024

@codewarnab Hey , today I tested the upload feature , but now its not working then i got to know in backend has some changes. In frontend I need to fixed this , for this I have to created new issue right? and also when i see in backend its have profile update info , so we have to update profile info also ( like name and phone number) ? because in frontend we are only able to update profile photo only.

what fix needed in the frontend anirban has given a commit see if this fix the issue you taliking about
i think you can update any each them separately their will be no issue i guess as anirban stated this here

@shilpashingnapure
Copy link
Contributor Author

shilpashingnapure commented May 26, 2024

okay , its already done. I have not seen commit of frontend my bad.
#286 this issue I have'nt seen , so i thought update user info is not done yet

shilpashingnapure added a commit to shilpashingnapure/Paws-frontend that referenced this issue May 26, 2024
rishicds pushed a commit that referenced this issue May 30, 2024
* enhancement of upload profile img | #348

* miskenly added comment is removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girl Script Summer of Code level3 45 points
Projects
None yet
Development

No branches or pull requests

4 participants