Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#279 contact information page made responsive #334

Merged
merged 9 commits into from
May 28, 2024

Conversation

Riddhi162
Copy link
Contributor

@Riddhi162 Riddhi162 commented May 15, 2024

Description

[Please include a brief description of the changes or features added]
I have made the contact details page completely responsive.For all the screens it is responsive.

Related Issue

#279

Screenshots / GIFs (if applicable)

[Attach any relevant screenshots or GIFs demonstrating the changes]
BEFORE:
Screenshot 2024-05-15 020112
AFTER:
Screenshot 2024-05-14 234249

Checklist:

  • I have performed a self-review of my code
  • I have added/updated relevant documentation (if needed)
  • I have tested the changes locally and they function as expected
  • I have ensured my code follows the project's coding standards

Additional Notes

[Add any additional notes or context about the changes made]

@rishicds
Copy link
Collaborator

Hi, please make the size of both buttons same, otherwise good work, itll be merged after that, also is it responsive on desktop?

@rishicds rishicds added level2 25 points gssoc Girl Script Summer of Code labels May 16, 2024
@codewarnab
Copy link
Collaborator

@Riddhi162 add screenshot for desktop

Copy link
Collaborator

@rishicds rishicds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Riddhi162 please update your branch and attach a screenshot of desktop

@Riddhi162
Copy link
Contributor Author

Riddhi162 commented May 16, 2024

@Riddhi162 add screenshot for desktop

Sure
Screenshot 2024-05-17 004141
Screenshot 2024-05-17 005645

I also made the button size same

@Riddhi162
Copy link
Contributor Author

Hi @Riddhi162 please update your branch and attach a screenshot of desktop

I edited the files here only and made the button size similar.Please check the commits.

@codewarnab
Copy link
Collaborator

@Riddhi162 add screenshot for desktop

Sure
Screenshot 2024-05-17 004141
Screenshot 2024-05-17 005645

I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

@codewarnab
Copy link
Collaborator

@Riddhi162 add screenshot for desktop

Sure
Screenshot 2024-05-17 004141
Screenshot 2024-05-17 005645

I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

Also make the buttons bigger and add space between them in desktop

@Riddhi162
Copy link
Contributor Author

@Riddhi162 add screenshot for desktop

Sure
Screenshot 2024-05-17 004141
Screenshot 2024-05-17 005645
I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

whose wiidth should i make to 60% the input field or its outer div?

@codewarnab
Copy link
Collaborator

codewarnab commented May 19, 2024

@Riddhi162 add screenshot for desktop

Sure
Screenshot 2024-05-17 004141
Screenshot 2024-05-17 005645
I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

whose wiidth should i make to 60% the input field or its outer div?

no leave it just make the buttons bigger and add space between them for desktop and solve the conflicts

@Riddhi162
Copy link
Contributor Author

@Riddhi162 add screenshot for desktop

Sure
Screenshot 2024-05-17 004141
Screenshot 2024-05-17 005645
I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

whose wiidth should i make to 60% the input field or its outer div?

no leave it just make the buttons bigger and add space between them for desktop and solve the conflicts

Done.

@codewarnab
Copy link
Collaborator

@Riddhi162 add screenshot for desktop

Sure
Screenshot 2024-05-17 004141
Screenshot 2024-05-17 005645
I also made the button size same

I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking

whose wiidth should i make to 60% the input field or its outer div?

no leave it just make the buttons bigger and add space between them for desktop and solve the conflicts

Done.

can you please add another screenshot how its looking now for mobile and desktop

@Riddhi162
Copy link
Contributor Author

Screenshot 2024-05-20 003302
Screenshot 2024-05-20 003322

@codewarnab
Copy link
Collaborator

Screenshot 2024-05-20 003302
Screenshot 2024-05-20 003322

I told you to add space in the desktop mode not in the mobile , also buttons are looking smaller than before in mobile

@Riddhi162
Copy link
Contributor Author

image
Okay made the changes for mobile view

@codewarnab
Copy link
Collaborator

thank you good job will be merged soon

@codewarnab
Copy link
Collaborator

@rishicds

@rishicds rishicds merged commit 27e39b7 into Innovateninjas:main May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girl Script Summer of Code level2 25 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants