Fix bug #265 #268
Merged
Fix bug #265 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "Set from mirror" is called for all bindings, function assumes all srcBindings should be copied, and generate bindings automatically if no paired binding exists in parameter. When "Set from mirror" is called for certain bindings, function assumed target binding is fixed, and searches source binding instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #265
Before patch #256 is applied "Set from mirror" worked as expected for binding context menu. But it didn't work correctly for key point context menu.
After applying patch, "Set from mirror" worked as expected for key point context menu, but not for binding context menu. This patch fixed the problem.
When "Set from mirror" is called for all bindings, function assumes all srcBindings should be copied, and generate bindings automatically if no paired binding exists in parameter. When "Set from mirror" is called for certain bindings, function assumed target binding is fixed, and searches source binding instead.