Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surpressed plaintext password in last.fm config #69

Merged
merged 3 commits into from
May 24, 2022
Merged

Surpressed plaintext password in last.fm config #69

merged 3 commits into from
May 24, 2022

Conversation

C-Lunn
Copy link
Contributor

@C-Lunn C-Lunn commented May 24, 2022

Addresses #68
Tested on Fedora 36.

Copy link
Owner

@InputUsername InputUsername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some small changes/questions

Cargo.toml Outdated Show resolved Hide resolved
src/service/lastfm.rs Outdated Show resolved Hide resolved
src/service/lastfm.rs Outdated Show resolved Hide resolved
@InputUsername InputUsername changed the base branch from master to development May 24, 2022 13:12
@C-Lunn
Copy link
Contributor Author

C-Lunn commented May 24, 2022

I'm new to Rust, I'm not sure what happened with the cargo.lock file but it seems to be a tracked file. It changed after I updated the version of rpassword and compiled with cargo build. I can remove it from the commit if necessary.

@InputUsername
Copy link
Owner

I'm new to Rust, I'm not sure what happened with the cargo.lock file but it seems to be a tracked file. It changed after I updated the version of rpassword and compiled with cargo build. I can remove it from the commit if necessary.

Cargo.lock pins package versions. It's changed because of adding rpassword, so if you could include it that would be great 😄

@C-Lunn
Copy link
Contributor Author

C-Lunn commented May 24, 2022

I'm new to Rust, I'm not sure what happened with the cargo.lock file but it seems to be a tracked file. It changed after I updated the version of rpassword and compiled with cargo build. I can remove it from the commit if necessary.

Cargo.lock pins package versions. It's changed because of adding rpassword, so if you could include it that would be great smile

Ran cargo build again and the version of rpassword seems to be correct now, pushed that Cargo.lock file.

@InputUsername InputUsername merged commit 290bcdf into InputUsername:development May 24, 2022
@InputUsername
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants