Make track album optional for ListenBrainz submissions #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
InputUsername
commented
Jan 18, 2023
InputUsername
commented
- ListenBrainz does not require album names for submissions, so they are now optional.
- rustfm-scrobble(-proxy) still requires the album, but this restriction could be lifted in the future.
- This does have the side effect of now treating empty album names (eg. "") the same as if they were missing from the MPRIS metadata.
InputUsername
force-pushed
the
development
branch
from
eb8c0c7
to
11e1d6a
Compare
rustfm-scrobble(-proxy) requires tracks to have an album
InputUsername
force-pushed
the
optional-album
branch
from
12b93de
to
2aef4ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.