Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to current-alpine to slim down Docker builds #191

Merged
merged 1 commit into from Feb 18, 2024

Conversation

kprinssu
Copy link
Contributor

This PR will change the base Docker images to use the latest Node version on top of the slimmed down Alpine images.

@kprinssu kprinssu closed this Feb 17, 2024
@Inrixia
Copy link
Owner

Inrixia commented Feb 17, 2024

Why was this closed?

@kprinssu
Copy link
Contributor Author

Apologies, I was making sure the container was functional and it is 🎉 !

@kprinssu kprinssu reopened this Feb 17, 2024
@Inrixia
Copy link
Owner

Inrixia commented Feb 17, 2024

What's the size difference of the image after these changes?

@kprinssu
Copy link
Contributor Author

It's about 2/3 size of the normal images:

# docker image ls | grep floatplane
kprinssu/floatplane-downloader        dev             789116f7076c   27 hours ago        237MB
inrix/floatplane-downloader           dev             90340801283b   5 days ago          301MB

The base alpine images remove a lot of cruft.

@Inrixia Inrixia merged commit 81a1da7 into Inrixia:dev Feb 18, 2024
3 checks passed
@Inrixia
Copy link
Owner

Inrixia commented Feb 18, 2024

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants