Added ffmpeg through docker, fetchFFMPEG removed #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker container icon also added.
|
This looks like it will cause the non headless version to fail if run outside of docker. Ill have to manually test off your fork before I can merge this. |
Inrixia
requested changes
Aug 30, 2021
There was a problem hiding this comment.
While this looks good, if not running in headless or outside of linux it will cause ffmpeg to be missing. Instead of removing fetchFFMPEG entirely it should only be disabled in a docker environment.
Note docker specifically as its possible to run headless outside of linux/docker.
|
#82 Should fix any issues with this. If issues crop up again in the future can look into implementing this properly. Thanks for the help regardless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with FFMPEG not being detected when downloading. This moves FFMPEG into the Dockerfile instead of when the container starts. Docker container icon also added.