Rebuild fixing Safari audio bug

InsanityRadio · Dec 24, 2017 · 82fc2cc · 82fc2cc
1 parent 9db1e84
commit 82fc2cc
Show file tree

Hide file tree

Showing 12 changed files with 210 additions and 732 deletions.
diff --git a/platforms/android/assets/www/app.bundle.js b/platforms/android/assets/www/app.bundle.js
diff --git a/platforms/android/assets/www/polyfills.bundle.js b/platforms/android/assets/www/polyfills.bundle.js
diff --git a/platforms/android/assets/www/vendor.bundle.js b/platforms/android/assets/www/vendor.bundle.js
diff --git a/platforms/browser/www/app.bundle.js b/platforms/browser/www/app.bundle.js
diff --git a/platforms/browser/www/polyfills.bundle.js b/platforms/browser/www/polyfills.bundle.js
diff --git a/platforms/browser/www/vendor.bundle.js b/platforms/browser/www/vendor.bundle.js
diff --git a/platforms/ios/ios.json b/platforms/ios/ios.json
@@ -64,7 +64,7 @@
           "CFBundleLocalizations": [
             {
               "xml": "<array><string>en</string></array>",
-              "count": 15
+              "count": 18
             }
           ]
         }

diff --git a/platforms/ios/www/app.bundle.js b/platforms/ios/www/app.bundle.js
diff --git a/platforms/ios/www/polyfills.bundle.js b/platforms/ios/www/polyfills.bundle.js
diff --git a/platforms/ios/www/vendor.bundle.js b/platforms/ios/www/vendor.bundle.js
diff --git a/src/app/radio.ts b/src/app/radio.ts
@@ -280,9 +280,11 @@ export module Radio {
 
 				// Firefox doesn't support HE-AAC on Mac for some reason. Bug 1387127
 				// It plays it as a AAC-LC which sounds worse than DAB.
+				// Safari has a similar effect at the start of every chunk. So fall back to Icecast!
 				let navi = navigator.userAgent.toLowerCase();
-				if (navi.indexOf('firefox') > -1 && navi.indexOf('macintosh') > -1) {
-					throw new Error('HLS with audio does not work on Firefox on macOS');
+				if ((navi.indexOf('firefox') > -1 && navi.indexOf('macintosh') > -1) ||
+						(navi.indexOf('safari') > -1 && navi.indexOf('chrome') == -1)) {
+					throw new Error('HLS with audio does not work on Firefox on macOS, or Safari.');
 				}
 
 			}
@@ -335,9 +337,7 @@ export module Radio {
 		}
 
 		playIfWaiting () {
-			console.log('erm')
 			if (this.waiting) {
-				console.log('about to play')
 				this.play();
 			}
 		}

diff --git a/www/app.bundle.js b/www/app.bundle.js