Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Histogram Filter Magic Numbers #1

Open
vjkoskela opened this issue Jul 1, 2019 · 0 comments
Open

Histogram Filter Magic Numbers #1

vjkoskela opened this issue Jul 1, 2019 · 0 comments

Comments

@vjkoskela
Copy link
Contributor

In HistogramFilterAggregator.java the method binInclusiveBound uses the value 45 without much explanation. This should at least extract this magic number into a private static final, and if a descriptive name is not possible, then the usage should also include a comment explaining this value and its meaning.
orborde added a commit that referenced this issue Feb 26, 2020
@orborde
Merge pull request #1 from InscopeMetrics/master
b28dd77 
Merge upstream!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vjkoskela