Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean themes (merge AC/FC themes & remove iron theme) #78

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

mboisnard
Copy link
Contributor

@mboisnard mboisnard commented Dec 16, 2022

Performs some clean/refactoring in order to understand how we use Keycloak themes and how we should implement the new theme convention (keycloak v2). (FC plugin is not configurable with Keycloak React New Admin Console for now)

  • Merge FC and AC themes
  • Remove iron theme

Signed-off-by: Mathieu Boisnard <mathieu.boisnard@lacombedulionvert.fr>
@clement-dufaure
Copy link
Collaborator

So a breaking change in theme id selection.
Next version will introduce breaking change related to the plugin configuration so it's a good time to.

@clement-dufaure clement-dufaure merged commit 7c2e7da into InseeFr:master Jun 23, 2023
2 checks passed
@mboisnard mboisnard deleted the clean/themes branch June 27, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants