Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous refactoring of code #326

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Conversation

johnksv
Copy link
Contributor

@johnksv johnksv commented Dec 16, 2023

Miscellaneous refactoring, no change in functionality. See commit for commit.

Print stack traces by using logger
Use new method for next tar, instead of the deprecated method
Other
Instead of returning null if the package was not found. This makes it easier to avoid NPE, which was present in the catalog controller
Uppercase variable name and static final
Just visual change
Copy link
Contributor

@olevitt olevitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks !
LGTM 👍

@olevitt olevitt merged commit b1d1e39 into InseeFrLab:main Dec 18, 2023
3 checks passed
@johnksv johnksv deleted the refactor branch December 18, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants