Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object mapper support comments, trailing commas and single quote #344

Merged
merged 5 commits into from Jan 10, 2024

Conversation

johnksv
Copy link
Contributor

@johnksv johnksv commented Jan 9, 2024

Solves #334

Implement features as described in fasterxml https://github.com/FasterXML/jackson-core/wiki/JsonReadFeatures

Go away from deprecated usage of objectmapper, and move to new method where builder object is used
Remove public modifier that is not necessary for test
Copy link
Contributor

@olevitt olevitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about the YAML mapper, what do you think ?

Only enable json features for json mapper. Cleanup qualifier which is same as specifying name on bean
Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johnksv johnksv requested a review from olevitt January 10, 2024 11:46
Copy link
Contributor

@olevitt olevitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@olevitt olevitt merged commit 7dc7d46 into InseeFrLab:main Jan 10, 2024
4 checks passed
@johnksv johnksv deleted the more-liberal-json-mapper branch January 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants