Cleanup some sonarcloud reported issues #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnksv
force-pushed
the
sonarcloud-fix-issues
branch
2 times, most recently
from
7bec769
to
acb0bcf
Compare
A good basis for further cleanup later as well - https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=InseeFrLab_onyxia-api&open=AYyCBqZxRJnw-QF9_Gfr - https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=InseeFrLab_onyxia-api&open=AYyCBqZxRJnw-QF9_Gfq - https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=InseeFrLab_onyxia-api&open=AYyCBqYTRJnw-QF9_Ge4 - https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=InseeFrLab_onyxia-api&open=AYyCBqWBRJnw-QF9_Gdg - https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=InseeFrLab_onyxia-api&open=AYyCBqV9RJnw-QF9_Gdd - https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=InseeFrLab_onyxia-api&open=AYyCBqV9RJnw-QF9_Gde - https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=InseeFrLab_onyxia-api&open=AYyCBqVoRJnw-QF9_GdT - https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=InseeFrLab_onyxia-api&open=AYyCBqXdRJnw-QF9_Gei - https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=InseeFrLab_onyxia-api&open=AYyCBqXuRJnw-QF9_Geq - https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=InseeFrLab_onyxia-api&open=AYyCBqYKRJnw-QF9_Ge0
johnksv
force-pushed
the
sonarcloud-fix-issues
branch
from
acb0bcf
to
26e26aa
Compare
|
johnksv
commented
Jan 11, 2024
| @@ -190,11 +190,11 @@ public UninstallService destroyApp( | |||
| @Parameter(hidden = true) Region region, | |||
| @Parameter(hidden = true) Project project, | |||
| @RequestParam(value = "path", required = false) String path, | |||
| @RequestParam(value = "bulk", required = false) boolean bulk) | |||
There was a problem hiding this comment.
Should we just remove this parameter, @olevitt ? Onyxia-web doesn't use it, e.g. for the 'delete all' onyxia-web send multiple delete calls (one for each service)
There was a problem hiding this comment.
I think it's ok to keep it as it may be useful for other clients (such as an admin tool that would cleanup)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for now, just for visibility that I am working on this one.
A good basis for further cleanup later as well