Add restrictions to catalogs based on user attributes #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By providing a restrictions-object to the catalogs.json we can now restrict which catalogs should be presented to the user based on some attribute they have. This may be useful in scenarios where one only wants certain users some catalogs. From this commit it still remain to implement a check on actual launch, as well at documentation of how the restrictions-object should be configured in the json Co-authored-by: Olivier Levitt <olivier.levitt@gmail.com>
johnksv
force-pushed
the
differantiate-catalogs
branch
from
d748ab8
to
8c0868c
Compare
Clearer separation of concerns, which also makes it easier to test
Such that the user can't launch a service he is not entitled to. Also rewrite to return optionals to make it clearer that it may actually be the case that the catalog may not exist in the user 'context'
johnksv
force-pushed
the
differantiate-catalogs
branch
from
8c0868c
to
f67330f
Compare
Such that it is more testable in future
johnksv
force-pushed
the
differantiate-catalogs
branch
from
1f1b3d4
to
8555c90
Compare
|
|
LGTM, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By providing a restrictions configuration to a catalog (in
catalogs.json) we can now restrict which catalogs should be presented to the user based on some attribute they have. This may be useful in scenarios where one only wants certain users some catalogs (i.e. differentiating catalogs based on some user trait).Catalogs which have some. restrictions will NOT be available on the public/catalogs endpoint. Instead a new endpoint under
/my-labis introduced.The restrictions are also enforced when the user try to launch a service.
Changes in the frontend are required.
This PR is backward compatible, in that case that catalogs without any restrictions are still available and can be launched by the user.