Various cleanups #370
Merged
Various cleanups #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnksv
commented
Feb 6, 2024
johnksv
commented
- Set field catalog in CatalogWrapper to a default object (additional fix to Improve readyness checks #338 )
- Field based injection to constructor based injection
- Add .java-version to project
- Remove redundant annotation
- Removed redundant annotation field
Such that the field exists when the catalogwrapper is returned from the API. This makes the API more consistent, that one always can expect the fields to exist. This will help prevent unnecessary errors for the consumer. The PR is somewhat kind of extension of the health check (which doesn't return 200 OK before the catalogs are loaded).
Some developers use a java version manager, like sdkman or jenv, if they develop on multiple projects with different jenv versions. By adding .java-version file the version manager can automatically set the correct java version in the project without the developer having to do this manually.
required = false is default for the Parameter and Schema annotation
|
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.