Add pause resume #413
Add pause resume #413
Conversation
| Region region, | ||
| Project project, | ||
| String catalogId, | ||
| Pkg pkg, | ||
| User user, | ||
| String serviceId, | ||
| boolean skipTlsVerify, | ||
| String caFile, | ||
| boolean dryRun) |
There was a problem hiding this comment.
Instead of duplicating these parameteres for so many methods, what do you think about packing these parameters into an DTO?
There was a problem hiding this comment.
Yeah, that would make a lot of sense. Got a headache yesterday working on parameters overloading 😆
There was a problem hiding this comment.
Another suggestion could be to have one method taking in a status, instead of having two methods (pause and resume).
If that make sense?
E.g.: public void update(Region region, ... , Status status where status is an enum (PAUSE,RESUME), i.e.. Maybe it could be possible to further refactor such that delete also is a part of that enum.
What do you think?
|
Implementing solution 1 from InseeFrLab/onyxia#791
Still needs to :