Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suspend / resume #431

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Fix suspend / resume #431

merged 3 commits into from
Jun 11, 2024

Conversation

olevitt
Copy link
Contributor

@olevitt olevitt commented Jun 11, 2024

Fix #430

This PR ensures that a service can be suspended / resumed even if the corresponding chart / version is not available anymore in Onyxia-API (e.g if skipPatches is on and a new version has been released).
Contrary to what was considered at some point in #430, we don't stealthy upgrade the package version as it could have un-intended consequences

@github-actions github-actions bot added the bug Something isn't working label Jun 11, 2024
@olevitt olevitt marked this pull request as ready for review June 11, 2024 12:41
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@olevitt olevitt merged commit 2c65164 into main Jun 11, 2024
8 checks passed
@olevitt olevitt deleted the fix-resume branch June 11, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspend / resume : use a newer chart if the specific version is not available
1 participant