Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes two reliability issues in CompatibilityChecks and CatalogRefresher (from SonarCloud) #435

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

trygu
Copy link
Contributor

@trygu trygu commented Jun 14, 2024

Fix: Handle InterruptedException correctly in CompatibilityChecks and CatalogRefresher

  • CompatibilityChecks:

    • Catch InterruptedException separately, re-interrupt the thread, and log the interruption.
    • Added CompatibilityChecksTest to verify proper handling of InterruptedException and other exceptions.
  • CatalogRefresher:

    • Catch InterruptedException in refresh method, re-interrupt the thread, and log the interruption.
    • Added CatalogRefresherTest to verify proper handling of InterruptedException, TimeoutException, and IOException.

Rated as medium issues on reliability on SonarCloud, and a nice excuse for adding more tests. 😄

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@olevitt
Copy link
Contributor

olevitt commented Jun 18, 2024

Looks good to me, thanks 👍

@olevitt olevitt merged commit 2c2d5ad into InseeFrLab:main Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants