New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight refactoring of the CatalogRefresh class #437

Merged

olevitt merged 1 commit into InseeFrLab:main from trygu:ammended-reliability-issues-sonarcloud

Jun 19, 2024

Contributor

trygu commented Jun 18, 2024

Refactor CatalogRefresher to handle InterruptedException properly and improve readability

Split refresh logic into separate methods: refreshCatalogs and updateRepo
Add detailed logging messages for better traceability
Properly re-interrupt and throw InterruptedException in updateRepo method
Update CatalogRefresherTest to cover additional scenarios and ensure thread interrupted status is handled
Added more tests and improved (hopefully) existing ones

Hopefully resolves the last reliability issue in SoneCloud.


          Refactor CatalogRefresher to handle InterruptedException properly and…

a45ef60

… improve readability

Contributor

olevitt commented Jun 19, 2024

Thank you !

olevitt merged commit 48fed70 into InseeFrLab:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment