koin-compose - Fix #1601 with stable parameter definition holder

InsertKoinIO · Sep 11, 2023 · deb1253 · deb1253
1 parent 9c7d8d3
commit deb1253
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/compose/koin-compose/src/commonMain/kotlin/org/koin/compose/Inject.kt b/compose/koin-compose/src/commonMain/kotlin/org/koin/compose/Inject.kt
@@ -17,6 +17,7 @@ package org.koin.compose
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.remember
+import org.koin.compose.stable.rememberStableParametersDefinition
 import org.koin.core.parameter.ParametersDefinition
 import org.koin.core.qualifier.Qualifier
 import org.koin.core.scope.Scope
@@ -49,8 +50,9 @@ inline fun <reified T> rememberKoinInject(
     qualifier: Qualifier? = null,
     scope: Scope = getKoinScope(),
     noinline parameters: ParametersDefinition? = null,
-): T = remember(qualifier, scope, parameters) {
-    scope.get(qualifier, parameters)
+): T {
+    val st = rememberStableParametersDefinition(parameters)
+    return remember(qualifier, scope) {
+        scope.get(qualifier, st.parametersDefinition)
+    }
 }
-
-
diff --git a/compose/koin-compose/src/commonMain/kotlin/org/koin/compose/stable/StableHolders.kt b/compose/koin-compose/src/commonMain/kotlin/org/koin/compose/stable/StableHolders.kt
@@ -0,0 +1,14 @@
+package org.koin.compose.stable
+
+import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
+import androidx.compose.runtime.remember
+import org.koin.core.parameter.ParametersDefinition
+
+@Stable
+class StableParametersDefinition(val parametersDefinition: ParametersDefinition?)
+
+@Composable
+fun rememberStableParametersDefinition(
+    parametersDefinition: ParametersDefinition?
+): StableParametersDefinition = remember { StableParametersDefinition(parametersDefinition) }