Does not support Kotlin 1.6.0 #1188

Nek-12 · 2021-10-21T16:49:53Z

Describe the bug
Latest koin version produces NoSuchMethodErrors at runtime when using kotlin 1.6.0-RC

To Reproduce
Steps to reproduce the behavior:

Add latest stable koin dependency
Use kotlin 1.6.0-RC.
App crashes on startup in 100% cases

Expected behavior
The app is able to run without crashing.

Koin project used and used version (please complete the following information):
[e.g]: koin version 3.1.2, kotlin 1.6.0-RC

The surest way to get a runtime error is to call a deleted method toDouble() of kotlin.duration that was removed in 1.6.0 by using

startKoin {
            androidContext(applicationContext)
            androidLogger() //This one is causing the crash
            modules(/* blah */)
        }

Stacktrace:

java.lang.NoSuchMethodError: No static method toDouble-impl(JLjava/util/concurrent/TimeUnit;)D in class Lkotlin/time/Duration; or its super classes (declaration of 'kotlin.time.Duration' appears in /data/app/~~RAEJCWfLUZeoA5jJfJMmtA==/com.nek.test.debug-jvqFgZyETecELyVm71SR5A==/base.apk!classes16.dex)
        at org.koin.core.time.MeasureKt.measureDuration(Measure.kt:32)
        at org.koin.core.KoinApplication.modules(KoinApplication.kt:59)
        at org.koin.core.KoinApplication.modules(KoinApplication.kt:50)
        at com.nek.test.TestApplication$onCreate$1.invoke(TestApplication.kt:30)
        at com.nek.test.TestApplication$onCreate$1.invoke(TestApplication.kt:27)
        at org.koin.core.context.GlobalContext.startKoin(GlobalContext.kt:64)
        at org.koin.core.context.DefaultContextExtKt.startKoin(DefaultContextExt.kt:31)
        at com.nek.test.TestApplication.onCreate(TestApplication.kt:27)
    //bunch of junk

Lesson: do not use experimental APIs

The text was updated successfully, but these errors were encountered:

franciscofranco · 2021-11-16T10:28:47Z

Hi. Any update on this issue? Kotlin 1.6.0 has been released to production and this crash happens, making it impossible to upgrade Kotlin...
Thanks.

SerggioC · 2021-11-16T11:28:20Z

same thing.
java.lang.NoSuchMethodError: No static method toDouble-impl(JLjava/util/concurrent/TimeUnit;)D in class Lkotlin/time/Duration; or its super classes (declaration of 'kotlin.time.Duration' appears in /data/app/..
Do I need to trash Koin or downgrade Kotlin?

victorlapin · 2021-11-16T12:50:15Z

Set Koin logger to level Error, as a workaround for the time being

    startKoin {
        androidLogger(if (BuildConfig.DEBUG) Level.ERROR else Level.NONE)
        androidContext(context)
        modules(allModules)
    }

SerggioC · 2021-11-16T15:58:25Z

Set Koin logger to level Error, as a workaround for the time being

    startKoin {
        androidLogger(if (BuildConfig.DEBUG) Level.ERROR else Level.NONE)
        androidContext(context)
        modules(allModules)
    }

That worked. Thanks.

arnaudgiuliani · 2021-11-29T10:01:17Z

Yes sorry, use this workaround for now.

jemshit · 2021-12-03T20:22:00Z

I remember another bug related to this androidLogger before 🧐

TreeFrogApps · 2021-12-04T23:55:19Z

Set Koin logger to level Error, as a workaround for the time being

    startKoin {
        androidLogger(if (BuildConfig.DEBUG) Level.ERROR else Level.NONE)
        androidContext(context)
        modules(allModules)
    }

For those creating their own Logger (for me I created a custom logger wrapping Timber) and not using AndroidLogger make sure to include this as the argument Level to the base Logger class, or anything that avoids Level.INFO and Level.DEBUG.

gmk57 · 2021-12-07T16:04:54Z

I remember another bug related to this androidLogger before 🧐

Yes, exactly the same happened when Kotlin 1.5 was released: #1076
Duration is nice, but we really should think twice before using experimental API in a public library.

jiurchuk · 2021-12-13T00:13:54Z

Workaround for Ktor:

install(Koin) {
    slf4jLogger(level = Level.ERROR) //This params are the workaround itself
    modules(
        //specify your modules
    )
}

EGFireball · 2021-12-14T08:32:34Z

Set Koin logger to level Error, as a workaround for the time being

    startKoin {
        androidLogger(if (BuildConfig.DEBUG) Level.ERROR else Level.NONE)
        androidContext(context)
        modules(allModules)
    }

This works ! Thanks !

muhrifqii · 2021-12-18T06:24:24Z

my case, also get rid of manually set logger for now

startKoin {
            androidLogger(Level.ERROR)
            //logger(object : Logger() {
            //    override fun log(level: Level, msg: MESSAGE) {
            //        Timber.tag("koin(di)").d(msg)
            //    }
            //})
            //...
}

carmelogallo · 2021-12-27T10:41:07Z

Hey guys, any news on this?

Using KMM I couldn't find a way to fix this crash. Even creating an ErrorLogger did not work for me.

startKoin {
    logger(ErrorLogger())
    appDeclaration?.invoke(this)
    modules(koinModules)
}

class ErrorLogger : Logger(Level.ERROR) {
    override fun log(level: Level, msg: MESSAGE) {
        println(msg)
    }
}

Any help?

athulcek · 2021-12-27T17:07:00Z

const val KOIN = "3.1.4"
const val KOTLIN = "1.6.0"
Crash Log:
Caused by: o6.c: Could not create instance for [Singleton:'v3.c']
in Release Build

lotdrops · 2022-01-06T13:12:42Z

@cikpis I got it working in KMM in two ways:

With an expect logger and actual implementations:
Common: expect val koinLogger: KoinApplication.() -> Unit
Android:

actual val koinLogger: KoinApplication.() -> Unit = {
    androidLogger(level = Level.ERROR)
}

iOS: actual val koinLogger: KoinApplication.() -> Unit = {}
Then, in the startKoin block you run koinLogger().

Providing platform app declarations to the koin init in shared:

internal fun initKoin(appDeclaration: KoinAppDeclaration = {}) =
    startKoin {
        appDeclaration()
        modules(
            // your modules...
        )
    }

Also in shared:

fun initKoinAndroid(appDeclaration: KoinAppDeclaration = {}) =
    initKoin(appDeclaration)

Then in the app module in Android, in MyApplication/BaseApplication:

initKoinAndroid() {
            androidLogger(Level.ERROR)
            androidContext(this@MyApplication)
            // optional: modules(appModule)
        }

carmelogallo · 2022-01-10T07:43:47Z

Thanks @lotdrops, I'll give it a try and keep you posted.

hoc081098 · 2022-01-11T18:17:54Z

any release for kotlin 1.6.0?

arnaudgiuliani · 2022-01-12T16:18:33Z

Koin 3.2.0 will bring Kotlin 1.6

* Updating Kotlin to 1.6.10 required updating some Compose dependencies to the next RC versions (which support a matching version of Kotlin) * Add support to use `ksp` for Moshi code-gen instead of using `kapt`. `kapt` will still be required as long as DataBinding is used in the project (see https://twitter.com/yigitboyar/status/1447408905240264704) * Workaround koin crash on launch caused by Kotlin 1.6.x update: InsertKoinIO/koin#1188 (comment) * Add additional unit test coverage in `:data` to bring coverage back up above 40% * Update other dependencies

adhirajsinghchauhan · 2022-01-27T10:18:29Z

Yes, exactly the same happened when Kotlin 1.5 was released: #1076
Duration is nice, but we really should think twice before using experimental API in a public library.

Goes back even further; Kotlin 1.4: #847

adhirajsinghchauhan · 2022-01-27T10:46:14Z

Koin 3.2.0 will bring Kotlin 1.6

Great news, but note that anyone who still targets SDK 29 won't be able to update to Koin 3.2.0:
Koin 3.1.3+ updates its androidx.activity:activity-ktx dependency to 1.3.1, which requires a minCompileSdk of 30.

Play Store required all app updates to target SDK 30 back in November 2021, but if you're not using it to publish apps, you're stuck with this workaround (suggested earlier in this thread):

startKoin {
    androidLogger(Level.ERROR) // default Level.INFO
    ...
}

gmk57 · 2022-01-27T19:02:26Z

anyone who still targets SDK 29 won't be able to update to Koin 3.2.0

What prevents you from having compileSdk 30 (or 31) and targetSdk 29 (or even lower)? They are completely different attributes. And despite old posts about library's targetSdk getting merged into resulting manifest, that doesn't seem to be the case nowadays.

Edit: Manifest merging rules clearly state that "attributes in the <uses-sdk> element always use the value from the higher-priority manifest" and "build configurations from the build.gradle file override any corresponding attributes in the merged manifest file".

arnaudgiuliani · 2022-02-03T09:18:34Z

Koin 3.2 is updated for Kotlin 1.6.10 👍

carmelogallo · 2022-02-03T14:28:19Z

@arnaudgiuliani great news! Do you guys know already when will it be released?

JyotimoyKashyap · 2022-02-18T16:15:12Z

Workaround for Ktor:

install(Koin) {
    slf4jLogger(level = Level.ERROR) //This params are the workaround itself
    modules(
        //specify your modules
    )
}

Thanks this works for me.

majidebraa · 2022-02-25T13:40:11Z

Koin 3.2 is updated for Kotlin 1.6.10 👍

3.2.0-beta-1 still does not work for me with Kotlin 1.6.10 and the app gets crash and generates these errors for all module injections:
org.koin.core.error.InstanceCreationException: Could not create an instance for [Factory:
org.koin.core.error.InstanceCreationException: Could not create instance for [Singleton:

victorlapin · 2022-02-25T16:31:56Z

Koin 3.2 is updated for Kotlin 1.6.10 👍

3.2.0-beta-1 still does not work for me with Kotlin 1.6.10 and the app gets crash and generates these errors for all module injections: org.koin.core.error.InstanceCreationException: Could not create an instance for [Factory: org.koin.core.error.InstanceCreationException: Could not create instance for [Singleton:

That's weird, because I've updated to 3.2.0-beta-1 in several different projects, and all worked fine. Maybe check your other artifacts, for example, DBInspector is using Koin as well, and it's linked with 3.1.4 (we've had to temporarily exclude it from our project)

alinegtcl · 2022-08-09T20:38:21Z

    startKoin {
        androidLogger(if (BuildConfig.DEBUG) Level.ERROR else Level.NONE)
        androidContext(context)
        modules(allModules)
    }

This works for me! Thanks!

Basitali12 · 2023-05-15T06:42:50Z

if any one facing issue like: No static method toDouble-impl(JLjava/util/concurrent/TimeUnit;)D in class Lkotlin/time/Duration; or its super classes (declaration of 'kotlin.time.Duration' appears in

so you need to change "androidLogger()" to androidLogger(if (BuildConfig.DEBUG) Level.ERROR else Level.NONE)

koin = startKoin {
// Koin Android logger

        androidLogger(if (BuildConfig.DEBUG) Level.ERROR else Level.NONE)
        //inject Android context
        androidContext(this)
        modules(modules)
    }

egorikftp mentioned this issue Nov 16, 2021

androidLogger() doesn't work with Kotlin 1.6 #1216

Closed

Nek-12 mentioned this issue Nov 17, 2021

Support Kotlin 1.6 stable version #1218

Closed

arnaudgiuliani added this to the 3.2.0 milestone Nov 18, 2021

arnaudgiuliani added core important 🔥 labels Nov 18, 2021

kjh5833 mentioned this issue Nov 19, 2021

kotlin 1.6.0 빌드 오류 iamport/iamport-android#47

Closed

hmiyado mentioned this issue Nov 23, 2021

feature/update-libraries hmiyado/kottage#121

Merged

This was referenced Nov 23, 2021

Insert-Koin Android Tutorial eucalypto/learn#50

Open

Koin DI & Android eucalypto/learn#54

Open

beiertu-mms mentioned this issue Dec 3, 2021

Surprisingly Koin crash at start Android app #1237

Closed

egorikftp mentioned this issue Dec 6, 2021

java.lang.NoSuchMethodError with kotlin 1.6 #1242

Closed

emirhanemmez mentioned this issue Dec 8, 2021

Not supporting Ktor 1.6.6 #1243

Closed

chanjungkim mentioned this issue Dec 9, 2021

java.lang.NoSuchMethodError: No static method toDouble-impl 에러 iamport/iamport-manual#50

Closed

jaredstockton mentioned this issue Jan 25, 2022

Dependency Updates BottleRocketStudios/Android-ArchitectureDemo#32

Merged

nitehu mentioned this issue Feb 1, 2022

Bump versions.kotlin from 1.5.31 to 1.6.10 ultrasonic/ultrasonic#648

Merged

arnaudgiuliani closed this as completed Feb 3, 2022

carmelogallo mentioned this issue Feb 7, 2022

Update Koin version to 3.2 splendo/kaluga#460

Closed

pubiqq mentioned this issue Apr 17, 2022

Avoid using ExperimentalTime API #1330

Closed

Thargelion mentioned this issue May 25, 2022

Feature/permission camera MuiaLeandro/duelosMeli#42

Merged

bohdan-go-wombat mentioned this issue Mar 15, 2024

[DIA-3574] Update SDK dependencies V1 SourcePointUSA/android-cmp-app#796

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Does not support Kotlin 1.6.0 #1188

Does not support Kotlin 1.6.0 #1188

Nek-12 commented Oct 21, 2021 •

edited

franciscofranco commented Nov 16, 2021

SerggioC commented Nov 16, 2021

victorlapin commented Nov 16, 2021 •

edited

SerggioC commented Nov 16, 2021

arnaudgiuliani commented Nov 29, 2021

jemshit commented Dec 3, 2021

TreeFrogApps commented Dec 4, 2021 •

edited

gmk57 commented Dec 7, 2021

jiurchuk commented Dec 13, 2021 •

edited

EGFireball commented Dec 14, 2021

muhrifqii commented Dec 18, 2021

carmelogallo commented Dec 27, 2021 •

edited

athulcek commented Dec 27, 2021

lotdrops commented Jan 6, 2022

carmelogallo commented Jan 10, 2022

hoc081098 commented Jan 11, 2022

arnaudgiuliani commented Jan 12, 2022

adhirajsinghchauhan commented Jan 27, 2022

adhirajsinghchauhan commented Jan 27, 2022

gmk57 commented Jan 27, 2022 •

edited

arnaudgiuliani commented Feb 3, 2022

carmelogallo commented Feb 3, 2022

JyotimoyKashyap commented Feb 18, 2022

majidebraa commented Feb 25, 2022

victorlapin commented Feb 25, 2022

alinegtcl commented Aug 9, 2022

Basitali12 commented May 15, 2023 •

edited

Does not support Kotlin 1.6.0 #1188

Does not support Kotlin 1.6.0 #1188

Comments

Nek-12 commented Oct 21, 2021 • edited

franciscofranco commented Nov 16, 2021

SerggioC commented Nov 16, 2021

victorlapin commented Nov 16, 2021 • edited

SerggioC commented Nov 16, 2021

arnaudgiuliani commented Nov 29, 2021

jemshit commented Dec 3, 2021

TreeFrogApps commented Dec 4, 2021 • edited

gmk57 commented Dec 7, 2021

jiurchuk commented Dec 13, 2021 • edited

EGFireball commented Dec 14, 2021

muhrifqii commented Dec 18, 2021

carmelogallo commented Dec 27, 2021 • edited

athulcek commented Dec 27, 2021

lotdrops commented Jan 6, 2022

carmelogallo commented Jan 10, 2022

hoc081098 commented Jan 11, 2022

arnaudgiuliani commented Jan 12, 2022

adhirajsinghchauhan commented Jan 27, 2022

adhirajsinghchauhan commented Jan 27, 2022

gmk57 commented Jan 27, 2022 • edited

arnaudgiuliani commented Feb 3, 2022

carmelogallo commented Feb 3, 2022

JyotimoyKashyap commented Feb 18, 2022

majidebraa commented Feb 25, 2022

victorlapin commented Feb 25, 2022

alinegtcl commented Aug 9, 2022

Basitali12 commented May 15, 2023 • edited

Nek-12 commented Oct 21, 2021 •

edited

victorlapin commented Nov 16, 2021 •

edited

TreeFrogApps commented Dec 4, 2021 •

edited

jiurchuk commented Dec 13, 2021 •

edited

carmelogallo commented Dec 27, 2021 •

edited

gmk57 commented Jan 27, 2022 •

edited

Basitali12 commented May 15, 2023 •

edited