Include throwable message in BeanInstanceCreationException #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, can you rebase your 3 commits into just 1? |
arnaudgiuliani
added
status:blocked
and removed
status:accepted
|
@caleb-allen Your PR need some rework. Thanks |
|
I'll take a look. I'm not sure that this is actually the best solution, any logs that come out of this is formatted as a standard string when really there should be a relationship between the thrown exception and the BeanInstanceCreationException. Thoughts? |
|
Well, I've patched the Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include throwable message from cause in BeanInstanceCreationException.
The use case for this is to prevent loss of information when System.err is not available, for example for crash logging libraries like Crashlytics.
Somewhat related to #74