Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include throwable message in BeanInstanceCreationException #124

Closed
wants to merge 3 commits into from
Closed

Include throwable message in BeanInstanceCreationException #124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e6e1f9
print exception message
May 10, 2018
b100bd8
get stacktrace
caleb-allen May 10, 2018
2ca5c20
get stacktrace
caleb-allen May 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion koin-core/src/main/kotlin/org/koin/core/instance/InstanceFactory.kt
View file
Open in desktop
Expand Up @@ -3,6 +3,10 @@ package org.koin.core.instance
import org.koin.core.bean.BeanDefinition
import org.koin.dsl.context.ParameterProvider
import org.koin.error.BeanInstanceCreationException
import java.io.PrintWriter
import java.io.StringWriter



/**
* Instance factory - handle objects creation against BeanRegistry
Expand Down Expand Up @@ -60,7 +64,10 @@ class InstanceFactory() {
return instance
} catch (e: Throwable) {
e.printStackTrace()
throw BeanInstanceCreationException("Can't create bean $def due to error :\n\t$e")
val sw = StringWriter()
e.printStackTrace(PrintWriter(sw))
val exceptionAsString = sw.toString()
throw BeanInstanceCreationException("Can't create bean $def due to error :\n\t$e; $exceptionAsString")
}
}

Expand Down