Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wasm support #1634

Closed
ygdrasil-io opened this issue Aug 10, 2023 · 28 comments
Closed

Add Wasm support #1634

ygdrasil-io opened this issue Aug 10, 2023 · 28 comments
Assignees
Milestone

Comments

@ygdrasil-io
Copy link

Is your feature request related to a problem? Please describe.
We would like to experiment the replacment of an old IoC system to Koin. korlibs/korge#1702
But the required Wasm target is not supported by koin.

Describe the solution you'd like
Add Wasm target.

Describe alternatives you've considered
Disabling Wasm as target but that will be counterproductive as we need to assess the technology.

Target Koin project
koin-core

@arnaudgiuliani
Copy link
Member

I will be happy to help. Wasm target has also been demanded in the community

@arnaudgiuliani arnaudgiuliani changed the title Add Wam support Add Wasm support Sep 13, 2023
@arnaudgiuliani
Copy link
Member

arnaudgiuliani commented Oct 30, 2023

@ygdrasil-io would be available to test dedicated release?

@joreilly
Copy link

joreilly commented Oct 30, 2023 via email

@arnaudgiuliani
Copy link
Member

oh yeah, thanks @joreilly

@arnaudgiuliani arnaudgiuliani added this to the core-wasm-3.5.2 milestone Nov 10, 2023
@mkonkel
Copy link

mkonkel commented Dec 2, 2023

I am building compose Multiplatform app with the wasm, is there possibility to test the proposed solution?

@nowiwr01w
Copy link

@arnaudgiuliani hi, can we test it with Compose Multiplatform for Web (Wasm)?

@arnaudgiuliani
Copy link
Member

I need a separated branch build for it. I will post here the RC releases that will be published

@sunildhiman90
Copy link

We are waiting for Wasm support. When new version will be released with Wasm support?

@lekalina
Copy link

+1

@arnaudgiuliani
Copy link
Member

arnaudgiuliani commented Dec 18, 2023

We are waiting for Wasm support. When new version will be released with Wasm support?

actively on it :)

will soon publish a rc version for wasm

@wagnod
Copy link

wagnod commented Dec 19, 2023

+1

@mahramane
Copy link

I am also waiting for Koin-wasm :)

@nowiwr01w
Copy link

+++++

@cryptrr
Copy link

cryptrr commented Dec 25, 2023

+1. Having good dependency support for kotlin-wasm will revolutionize the web.

@nowiwr01w
Copy link

@arnaudgiuliani How is it going?

@mdsadiqueinam
Copy link

+1

1 similar comment
@dimagor555
Copy link

+1

@andres04
Copy link

andres04 commented Jan 6, 2024

Any news?

@stephen2earth
Copy link

Any update?

@arnaudgiuliani
Copy link
Member

arnaudgiuliani commented Jan 25, 2024

3.6.0-wasm-alpha1 is out 🎉

https://github.com/InsertKoinIO/koin/blob/3.6.0-wasm/projects/core/koin-core/build.gradle.kts#L19

@arnaudgiuliani arnaudgiuliani modified the milestones: wasm-3.5.3, wams-3.6.0 Jan 25, 2024
@c4software
Copy link

Hi @arnaudgiuliani could you update the 3.6.0 version to use the newer ComposePlugin 1.6.0-rc2 tag?

The previous one is binary incompatible with rc1 and up and causing problems during the build of iOS target.

See
JetBrains/compose-multiplatform#4277 (comment)

@arnaudgiuliani
Copy link
Member

Ok, yes 👍

@hoc081098
Copy link
Contributor

Compose 1.6.0 released.

@arnaudgiuliani
Copy link
Member

good news. Let's see fot official release. But it will land in Koin 3.6 branch

hoc081098 added a commit to hoc081098/kmp-viewmodel that referenced this issue Feb 29, 2024
* compose wasm

* koject: update
mori-atsushi/koject#312

* compose wasm

* compose wasm

* compose: use `browser()` instead of NodeJS.

* compose: use `browser()` instead of NodeJS.

* changelog

* docs for koject

* docs for koject

* Update CHANGELOG.md

- `kmp-viewmodel-koin` and `kmp-viewmodel-koin-compose`: blocked by InsertKoinIO/koin#1634
@sureshmaidaragi1919
Copy link

sureshmaidaragi1919 commented Mar 6, 2024

Is koin started supporting Jetpack compose v1.6.0?, I tried accessing 3.6.0-alpha3 seeing below issue

Screenshot 2024-03-06 at 6 32 11 PM

@joreilly
Copy link

joreilly commented Mar 6, 2024

The koin-compose version is 1.2.0-alpha3 (example of it's use in https://github.com/joreilly/ClimateTraceKMP)

@arnaudgiuliani
Copy link
Member

will update 3.6 soon :)

@arnaudgiuliani
Copy link
Member

3.6.0-Beta5 is out. 4.0.0 will continue with wasm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests