-
-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand resolve api #1225
Merged
arnaudgiuliani
merged 14 commits into
InsertKoinIO:3.2.x
from
marcellogalhardo:expand-resolve-api
Jan 11, 2022
Merged
Expand resolve api #1225
arnaudgiuliani
merged 14 commits into
InsertKoinIO:3.2.x
from
marcellogalhardo:expand-resolve-api
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! |
Great work @marcellogalhardo. check the remaining conflict. I can help to setup some doc around |
arnaudgiuliani
approved these changes
Dec 7, 2021
d0f706d
to
c332a60
Compare
…r make it easier to find the files
This reverts commit cb39f02
c332a60
to
cd221dc
Compare
Hey @arnaudgiuliani - I believe all conflicts are solved now. Let me know if anything is missing. |
Great. Seems ready to go to 3.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the Pull Request of constructor resolution and @arnaudgiuliani suggestion as improvement, the following PR adds new methods for resolve
factory
,single
andviewModel
- including support forqualifier
or not.That is how it looks like:
The Pull Request includes:
viewModelOf
singleOf
factoryOf
scopedOf
Original Pull Request (with discussion): #1206
Fixes #1029