fix(flatten): use LinkedHashSet instead of HashSet

[hoc081098]

to maintain the insertion order

[arnaudgiuliani]

still get error, but order is maintained in the reverse order I see 🤔

@Test
    fun `allow overrides by type`() {
        val app = koinApplication {
            modules(
                module {
                    single<Simple.ComponentInterface1> { Simple.Component2() }
                },
                module {
                    single<Simple.ComponentInterface1> { Simple.Component1() }
                },
            )
        }

        app.assertDefinitionsCount(1)
        assertTrue(app.koin.get<Simple.ComponentInterface1>() is Simple.Component1)
    }

Good thing is that order seems stable

[arnaudgiuliani]

Could test that with this test too:

@Test
    fun test_flatten_list() {

        (1..100).all { i ->
            val modules = listOf(module { },module { },module { },module { },module { },module { },module { },module { },module { },module { })
            val flatten = flatten(modules)
            flatten.reversed() == modules
        }
    }

[hoc081098]

@arnaudgiuliani just updated

-ArrayDeque(modules)
+ArrayDeque(modules.asReversed())

[arnaudgiuliani]

Sounds good 🎉. Need to check the fails on test examples 🤔

[arnaudgiuliani]

Seen the problem. It's not from your side 👍 Will fix it