Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkmodules deprecation #1867

Merged
merged 3 commits into from
May 3, 2024
Merged

Checkmodules deprecation #1867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00880ae
libraries update
arnaudgiuliani May 3, 2024
d9b53e5
examples update + Beta4
arnaudgiuliani May 3, 2024
3378cbc
Deprecate checkModules() API in favor of better verify() API
arnaudgiuliani May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions examples/gradle/versions.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ ext {
// Kotlin
kotlin_version = '1.9.23'
// Koin Versions
koin_version = '3.6.0-Beta2'
koin_version = '3.6.0-Beta4'
koin_android_version = koin_version
koin_compose_version = "1.2.0-Beta2"
koin_compose_version = "1.2.0-Beta4"

coroutines_version = "1.8.0"
ktor_version = "2.3.9"
ktor_version = "2.3.10"
// Compose
compose_compiler = "1.5.11"
jb_compose_version = "1.6.1"
jb_compose_version = "1.6.2"

// Test
junit_version = "4.13.2"
Expand All @@ -22,5 +22,5 @@ ext {
android_min_version = 14
android_target_version = 34
android_build_tools_version = '33.0.1'
android_gradle_version = '7.4.1'
android_gradle_version = '7.4.2'
}
4 changes: 4 additions & 0 deletions projects/core/koin-test/src/commonMain/kotlin/org/koin/test/check/CheckModules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import org.koin.test.parameter.MockParameter
/**
* Check all definition's dependencies - start all modules and check if definitions can run
*/
@Deprecated("Migrate to verify() API")
fun KoinApplication.checkModules(parameters: CheckParameters? = null) = koin.checkModules(parameters)

/**
Expand All @@ -49,6 +50,7 @@ fun KoinApplication.checkModules(parameters: CheckParameters? = null) = koin.che
* @param parameters - parameter setup
* @param appDeclaration - koin Application
*/
@Deprecated("Migrate to verify() API")
fun checkModules(level: Level = Level.INFO, parameters: CheckParameters? = null, appDeclaration: KoinAppDeclaration) {
startKoin(appDeclaration)
.logger(KoinPlatformTools.defaultLogger(level))
Expand All @@ -62,6 +64,7 @@ fun checkModules(level: Level = Level.INFO, parameters: CheckParameters? = null,
* @param appDeclaration - Koin app config if needed
* @param parameters - Check parameters DSL
*/
@Deprecated("Migrate to verify() API")
fun checkKoinModules(modules: List<Module>, appDeclaration: KoinAppDeclaration = {}, parameters: CheckParameters? = null) {
startKoin(appDeclaration)
.modules(modules)
Expand Down Expand Up @@ -98,6 +101,7 @@ fun checkKoinModules(vararg modules: Module, level: Level = Level.INFO, paramete
/**
* Check all definition's dependencies - start all modules and check if definitions can run
*/
@Deprecated("Migrate to verify() API")
fun Koin.checkModules(parametersDefinition: CheckParameters? = null) {
logger.info("[Check] checking modules ...")

Expand Down
2 changes: 2 additions & 0 deletions projects/core/koin-test/src/commonMain/kotlin/org/koin/test/check/CheckModulesDSL.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ import kotlin.reflect.KClass

//TODO TO BE DEPRECATED in 3.6

@Deprecated("Migrate to verify() API")
data class CheckedComponent(val qualifier: Qualifier? = null, val type: KClass<*>)

@Deprecated("Migrate to verify() API")
class ParametersBinding(val koin: Koin) {

val parametersCreators = mutableMapOf<CheckedComponent, ParametersCreator>()
Expand Down
4 changes: 2 additions & 2 deletions projects/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ org.gradle.parallel=true
kotlin.code.style=official

#Koin
koinVersion=3.6.0-Beta3
koinComposeVersion=1.2.0-Beta3
koinVersion=3.6.0-Beta4
koinComposeVersion=1.2.0-Beta4

#Compose
jetpackComposeCompiler=1.5.11
Expand Down
10 changes: 5 additions & 5 deletions projects/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ dokka = "1.9.10"
# Android
agp = "7.4.2"
android-appcompat = "1.6.1"
android-activity = "1.8.2"
android-fragment = "1.6.2"
android-activity = "1.9.0"
android-fragment = "1.7.0"
androidx-viewmodel = "2.7.0"
androidx-commonJava8 = "2.7.0"
androidx-workmanager = "2.9.0"
androidx-navigation = "2.7.7"
# Compose
# /!\ Compose compiler in gradle.properties /!\
composeJB = "1.6.1"
composeJetpackRuntime = "1.6.5"
composeJB = "1.6.2"
composeJetpackRuntime = "1.6.7"
composeJetpackViewmodel = "2.7.0"
# Test
stately = "2.0.6"
Expand All @@ -29,7 +29,7 @@ jupiter = "5.9.3"
mockito = "4.7.0"
mockk = "1.13.2"
# Ktor
ktor = "2.3.9"
ktor = "2.3.10"
slf4j = "1.7.36"

[libraries]
Expand Down
Loading