RXR-819: return percentile when weight is right at 0.1st #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmineirx
approved these changes
Feb 3, 2022
Co-authored-by: Jasmine Hughes <43552465+jasmineirx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were returning
NAas the percentile when the provided value was exactly at the 0.1st percentile. The reason was thattail(as.num(tmp[value > as.num(tmp)]),1)did not include any values, so thedatadata frame had only one row. Therefore when we fitlm()there was an intercept but the slope wasNA, and when we addedas.num(par[1] + par[2]*value)that producedNA. This fixes it by using<=and>=, rather than<and>, to check for values at the 99.9th or 0.1st percentile.