Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NCA corrections #35

Merged
merged 15 commits into from
Mar 1, 2022
Merged

NCA corrections #35

merged 15 commits into from
Mar 1, 2022

Conversation

roninsightrx
Copy link
Contributor

  • fix for proper calculation of V (and CL), was assuming bolus also in case of infusion
  • fix for correct calculation of peak extension (was double counting some AUC)
  • add new method "log_log" that appropriately calculates AUC during infusion.

@jasmineirx jasmineirx mentioned this pull request Feb 28, 2022
Closed
@roninsightrx
Copy link
Contributor Author

thx for adding the unit tests!

jasmineirx
jasmineirx approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@jasmineirx jasmineirx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a couple minor comments. note that i also added some unit tests and changed a line of code.

R/nca.R Outdated Show resolved Hide resolved
R/nca.R Show resolved Hide resolved
@roninsightrx roninsightrx merged commit 7819253 into master Mar 1, 2022
@roninsightrx roninsightrx deleted the corrections branch March 1, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmineirx jasmineirx jasmineirx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roninsightrx @jasmineirx