submit to CRAN #38
Merged
submit to CRAN #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rhub turned up the following, as well as a couple more URL issues (some returning a 403 error, but I don't see that when I try to visit them 😕 )
|
RXR-959: Replace `class() == ` with `inherits()`
Shall we just explain in CRAN notes that they URLs are fine? |
Ah you did, nm. |
This is causing a NOTE for the current CRAN version of clinPK, and is unnecessary since clinPK does not package any data
karawoo
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a news.md for the release. Only needs a cran.md, and then ready for release to CRAN.