RXR-252: Remove download argument to read_who_table() #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables are no longer available at the URL and we haven't found an alternate location
jasmineirx
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
downloadandwho_urlarguments toread_who_table()since the tables are no longer found there.Also added some tests for
read_who_table()since it did not have any.In
pct_for_age_generic()we were specifyingdownload = FALSEso I removed that. I checked insightrxr and didn't find any places where we were using the argument there, but if we wanted to be extra safe we could keep the argument names, but have them throw a warning and fall back to the packaged datasets.