ENH: Test bool return value of TransformPhysicalPoint member functions

Print the `bool` return values of `TransformPhysicalPointToIndex` and `TransformPhysicalPointToContinuousIndex`, in tests from "Core/Common". The apparently accidentally ignored return values were found by using the C++17 `[[nodiscard]]` attribute, as part of pull request #3993
InsightSoftwareConsortium · Apr 5, 2023 · 1d03697 · 1d03697
1 parent d010963
commit 1d03697
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/Modules/Core/Common/test/itkImageTransformTest.cxx b/Modules/Core/Common/test/itkImageTransformTest.cxx
@@ -61,11 +61,13 @@ TestTransform()
   std::cout << "    Image:         " << index << " -> " << point << std::endl;
 
   std::cout << "TransformPhysicalPointToIndex..." << std::endl;
-  orientedImage->TransformPhysicalPointToIndex(point, index);
-  std::cout << "    Image: " << point << " -> " << index << std::endl;
+  const bool isInsideOrientedImage = orientedImage->TransformPhysicalPointToIndex(point, index);
+  std::cout << "    Image: " << point << " -> " << index << (isInsideOrientedImage ? " inside" : " outside")
+            << std::endl;
 
-  image->TransformPhysicalPointToIndex(point, index);
-  std::cout << "    Image:         " << point << " -> " << index << std::endl;
+  const bool isInsideImage = image->TransformPhysicalPointToIndex(point, index);
+  std::cout << "    Image:         " << point << " -> " << index << (isInsideImage ? " inside" : " outside")
+            << std::endl;
 }
 
 int

diff --git a/Modules/Core/Common/test/itkPhasedArray3DSpecialCoordinatesImageTest.cxx b/Modules/Core/Common/test/itkPhasedArray3DSpecialCoordinatesImageTest.cxx
@@ -64,10 +64,11 @@ itkPhasedArray3DSpecialCoordinatesImageTest(int, char *[])
 
   point.Fill(0.05);
   point[2] = 3.1;
-  image->TransformPhysicalPointToIndex(point, index);
-  std::cout << "Point " << point << " -> Index " << index << std::endl;
-  image->TransformPhysicalPointToContinuousIndex(point, continuousIndex);
-  std::cout << "Point " << point << " -> Continuous Index " << continuousIndex << std::endl;
+  const bool isIndexInside = image->TransformPhysicalPointToIndex(point, index);
+  std::cout << "Point " << point << " -> Index " << index << (isIndexInside ? " inside" : " outside") << std::endl;
+  const bool isContinuousIndexInside = image->TransformPhysicalPointToContinuousIndex(point, continuousIndex);
+  std::cout << "Point " << point << " -> Continuous Index " << continuousIndex
+            << (isContinuousIndexInside ? " inside" : " outside") << std::endl;
 
   if (index[0] != 2 || index[1] != 2 || index[2] != 1)
   {