Skip to content

Commit

Permalink
PERF: Use faster TransformPhysicalPointToIndex/ContinuousIndex in Python
Browse files Browse the repository at this point in the history
Replaced calls to TransformPhysicalPointToIndex(point, idx) and
TransformPhysicalPointToContinuousIndex(point, idx) by the corresponding faster
overloads.

Aims to address warnings at Windows_NT-Build3495-master-Python
https://open.cdash.org/viewBuildError.php?type=1&buildid=8615447 saying:

> s-build\Wrapping\Modules\ITKCommon\itkImagePython.cpp: warning C4834:
> discarding return value of function with 'nodiscard' attribute
  • Loading branch information
N-Dekker authored and dzenanz committed Apr 13, 2023
1 parent 455b06b commit 87b48e4
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions Wrapping/Generators/Python/PyBase/pyBase.i
Expand Up @@ -476,15 +476,11 @@ str = str
%rename(__SetDirection_orig__) swig_name::SetDirection;
%extend swig_name {
itkIndex##template_params TransformPhysicalPointToIndex( itkPointD##template_params & point ) {
itkIndex##template_params idx;
self->TransformPhysicalPointToIndex<double>( point, idx );
return idx;
return self->TransformPhysicalPointToIndex( point );
}
itkContinuousIndexD##template_params TransformPhysicalPointToContinuousIndex( itkPointD##template_params & point ) {
itkContinuousIndexD##template_params idx;
self->TransformPhysicalPointToContinuousIndex<double>( point, idx );
return idx;
return self->TransformPhysicalPointToContinuousIndex<itkContinuousIndexD##template_params::ValueType>( point );
}
itkPointD##template_params TransformContinuousIndexToPhysicalPoint( itkContinuousIndexD##template_params & idx ) {
Expand Down

0 comments on commit 87b48e4

Please sign in to comment.