Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WriteCompilerDetectionHeader #2573

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Jun 3, 2021

This is a follow-up to and partial reversal of #2464. Closes #2465.

We now require C++14, which includes all of the granular
C++11 features which used to be detected before.

@github-actions github-actions bot added area:Core Issues affecting the Core module area:ThirdParty Issues affecting the ThirdParty module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Jun 3, 2021
@dzenanz dzenanz force-pushed the cmake320policies branch 3 times, most recently from 3888d5c to 03082e8 Compare June 8, 2021 13:50
@github-actions github-actions bot added area:Filtering Issues affecting the Filtering module type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Jun 8, 2021
@thewtex thewtex requested a review from hjmjohnson June 8, 2021 20:57
VXL Maintainers and others added 3 commits July 15, 2021 12:30
Code extracted from:

    https://github.com/vxl/vxl.git

at commit d8888fd569207d21a634bd998401143c714810d5 (master).
# By VXL Maintainers
* upstream-VXL:
  VXL 2021-07-15 (d8888fd5)
This is a follow-up to and partial reversal of InsightSoftwareConsortium#2464. Closes InsightSoftwareConsortium#2465.

We now require C++14, which includes all of the granular
C++11 features which used to be detected before.
@dzenanz
Copy link
Member Author

dzenanz commented Jul 15, 2021

This PR requires #2647, so it is rebased on top of it.

@dzenanz dzenanz mentioned this pull request Jul 15, 2021
7 tasks
@dzenanz dzenanz merged commit 9d474f9 into InsightSoftwareConsortium:master Jul 16, 2021
@dzenanz dzenanz deleted the cmake320policies branch July 20, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:ThirdParty Issues affecting the ThirdParty module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WriteCompilerDetectionHeader module is removed in CMake 3.20
2 participants