Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please use UTC timestamp in CMake to enable reproducibility #3072

Closed
tillea opened this issue Jan 10, 2022 · 0 comments · Fixed by #3073
Closed

Please use UTC timestamp in CMake to enable reproducibility #3072

tillea opened this issue Jan 10, 2022 · 0 comments · Fixed by #3073
Labels
type:Style Style changes: no logic impact (indentation, comments, naming)

Comments

@tillea
Copy link

tillea commented Jan 10, 2022

Description

As per Debian bug report ITK does not build reproducible.

Expected coding style

This patch against version 5.2.1 fixes the issue.

Additional Information

No idea whether "Coding Style Inconsistency" is the proper category - but its not really a bug...

Kind regards
Andreas.
@tillea tillea added the type:Style Style changes: no logic impact (indentation, comments, naming) label Jan 10, 2022
dzenanz pushed a commit to dzenanz/ITK that referenced this issue Jan 10, 2022
@vagrantc @dzenanz
ENH: Use UTC timestamp in CONFIGURE_DATE.
89b8fd3 
While cmake respects SOURCE_DATE_EPOCH, the timezone may still change
the embedded timestamp used.

https://reproducible-builds.org/docs/source-date-epoch/

Closes InsightSoftwareConsortium#3072.
@dzenanz dzenanz mentioned this issue Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Use UTC timestamp in CONFIGURE_DATE. dzenanz/ITK
1 participant
@tillea