Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Set runtime output path for external module binaries #2245

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Jan 8, 2021

Addresses crashing test driver on Windows with shared libraries.

Addresses crashing test driver on Windows with shared libraries.
@dzenanz
Copy link
Member

dzenanz commented Jan 8, 2021

Is this why some remote modules have test failures?

@thewtex
Copy link
Member Author

thewtex commented Jan 8, 2021

Is this why some remote modules have test failures?

I tested it with ITKModuleTemplate, but it should impact many.

Copy link
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested, but 💯.

@thewtex thewtex merged commit abd38d5 into InsightSoftwareConsortium:master Jan 9, 2021
@thewtex thewtex deleted the external-module-runtime-paths branch January 9, 2021 02:23
thewtex added a commit to thewtex/ITKModuleTemplate that referenced this pull request Jan 9, 2021
thewtex added a commit to thewtex/ITKModuleTemplate that referenced this pull request Jan 9, 2021
thewtex added a commit to thewtex/ITKModuleTemplate that referenced this pull request Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants