Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update to newer third-party update script from CMake #2291

Merged

Conversation

bradking
Copy link
Member

Use the CMake Utilities/Scripts/update-third-party.bash as of commit
693f4c70ff. Manually preserve ITK's change from commit 5dccc22
(BUG: Do not gpg sign third party updates, 2018-11-19, v5.0b02~82^2~1).

Use the CMake `Utilities/Scripts/update-third-party.bash` as of commit
`693f4c70ff`.  Manually preserve ITK's change from commit 5dccc22
(BUG: Do not gpg sign third party updates, 2018-11-19, v5.0b02~82^2~1).
@bradking bradking mentioned this pull request Feb 10, 2021
@bradking
Copy link
Member Author

@thewtex this needs to be merged to both release and master. It's needed to make third-party updates easier. See the trouble encountered in #2290 for an example.

@seanm
Copy link
Contributor

seanm commented Feb 10, 2021

Thanks for the fix!

@thewtex
Copy link
Member

thewtex commented Feb 10, 2021

@bradking thanks!

Merging to master now -- we will release 5.2 RC 2 over the next few days, and I will update release at that time.

@thewtex thewtex merged commit 3cef6d4 into InsightSoftwareConsortium:release Feb 10, 2021
@dzenanz
Copy link
Member

dzenanz commented Feb 10, 2021

This was merged into release branch, as that was the target of the PR. I will merge it into master too.

@bradking bradking deleted the update-third-party branch February 10, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants