New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add numbers to the three itkPyBufferMemoryLeakTest
print messages
#2578
ENH: Add numbers to the three itkPyBufferMemoryLeakTest
print messages
#2578
Conversation
Add numbers (1, 2, 3) to the print messages in itkPyBufferMemoryLeakTest, to ease analysis of the output from a test failure.
941c4a2
to
fbb5158
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incremental build didn't work for me, I needed to manually rebuild something to avoid a clean build.
While it is possible that PR did it, I see no reason why it would do that. This same test used to be flaky on Mac before, if I remember correctly.
I don't know either. Would it matter that these
ITK/Modules/Core/Common/wrapping/itkImageDuplicator.wrap Lines 11 to 13 in cd36c64
|
This is a follow-up to #2554, suggested in #2578 (comment)
Even if it does not fix the pyBuffer memory leak, ImageDuplicator should be wrapped with LL types. -> Done in #2584. |
This is a follow-up to #2554, suggested in #2578 (comment)
This is a follow-up to #2554, suggested in #2578 (comment)
Add numbers (1, 2, 3) to the print messages in itkPyBufferMemoryLeakTest,
to ease analysis of the output from a test failure.