Python readimage improvement series imageio #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewtex
reviewed
Dec 4, 2018
There was a problem hiding this comment.
Awesome @fbudin69500 !
A minor documentation comment and probably want to update the commit message for the second commit -- as I see it, we just pass an array into itk.imread for a series, 👍 , instead of needing a different API call.
SimonRit
approved these changes
Dec 5, 2018
added 3 commits
December 5, 2018 20:48
When using itk.ImageFileReader to automatically select the image type based on the image information, the user can now
itkTemplate image reading mechanism allows the user to not have to select image type (pixel type and dimension). The same mechanism now also works for image series.
If `itk.imread()` first argument is a list or a tuple, it will read it as an image series. This can be used in combination with `itk.NumericSeriesFileNames` for example.
fbudin69500
force-pushed
the
python_readimage_improvement_series_imageio
branch
from
65c4a6a
to
379702b
Compare
|
@fbudin69500 How does this differ from #259 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how images and image series are read using ITK Python.
Image series can now be read the same way single image files could already be read, relying on the automatic pixel type and image dimension detection. This can be done both by explicitly calling itk.ImageSeriesReader.New(FileNames=["xxx", "yyy"]) or by using the Pythonic function itk.imread(["xxx", "yyy"]) providing a list of images to the function.
When using itk.ImageFileReader.New() or itk.ImageSeriesReader.New() to read an image for which the pixel type and image dimension is automatically detected, one can now specify which image IO is going to be used. Previously, this could only be done if the pixel type and image dimension were manually specified; Otherwise, the image IO was selected automatically.