Bad cmake find itk wrap image dims #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2018 22:09
This is a fix for previous commit [1] which introduced some small problems when moving Python tests from the Python Wrapping folder to each module folder. When verifying for which image dimension the wrapping is activated, at the module level, one cannot directly on the CMake variable WRAP_2 which is not initialized in most cases (it would have to be initialized inside the current CMakeLists.txt as it is a local CMake variable). Instead, rely on ITK_WRAP_IMAGE_DIMS which is a CACHE variable and therefore available throughout the project. Addionally, the CMake command `list(FIND` requires the CMake list that is passed to be given by its variable name, not expanded. [1] 391d98a
Several tests had the wrong path images they were trying to find to run tests.
thewtex
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses problems introduced when moving Python tests from the global Wrapping/Generators/Python directory to their individual module directory.