New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetaIO: Update to 2021-09-28 (5e87f062) #2761
MetaIO: Update to 2021-09-28 (5e87f062) #2761
Conversation
@bradking I guess we need to migrate the update script to the new version? |
Yes, |
Update to `update-common.sh` from commit `7134d5ebef` in https://gitlab.kitware.com/utils/git-import-third-party Manually preserve ITK's change from commit 5dccc22 (BUG: Do not gpg sign third party updates, 2018-11-19, v5.0b02~82^2~1).
Code extracted from: https://github.com/Kitware/MetaIO.git at commit 3f37ad783fb2d5a633dc1faef8fc6cd9f00710bf (3f37ad783fb2d5a633dc1faef8fc6cd9f00710bf).
Code extracted from: https://github.com/Kitware/MetaIO.git at commit 5e87f062ea796204b84fc3e5e9100cd3ead2e015 (master).
# By MetaIO Maintainers * upstream-MetaIO: MetaIO 2021-09-28 (5e87f062)
2499172
to
ed5c976
Compare
FYI, #2659 was not done with the proper history shape. That's what caused the update here with the old script to fail. I manually built a fixed history shape to recover and switch to the new update script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve my own PR, but it looks good.
And thank you, Brad! |
@codeling The script runs on Linux without major deletions but still does not seem to work properly.