Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaIO: Update to 2021-09-28 (5e87f062) #2761

Merged
merged 6 commits into from Sep 30, 2021

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Sep 29, 2021

@codeling The script runs on Linux without major deletions but still does not seem to work properly.

@dzenanz
Copy link
Member Author

dzenanz commented Sep 29, 2021

@bradking I guess we need to migrate the update script to the new version?

@bradking
Copy link
Member

Yes, Modules/ThirdParty/MetaIO/UpdateFromUpstream.sh should be converted from UpdateThirdPartyFromUpstream.sh to update-third-party.bash. I'll take a look.

bradking and others added 6 commits September 29, 2021 14:51
Update to `update-common.sh` from commit `7134d5ebef` in

    https://gitlab.kitware.com/utils/git-import-third-party

Manually preserve ITK's change from commit 5dccc22 (BUG: Do not gpg
sign third party updates, 2018-11-19, v5.0b02~82^2~1).
Code extracted from:

    https://github.com/Kitware/MetaIO.git

at commit 3f37ad783fb2d5a633dc1faef8fc6cd9f00710bf (3f37ad783fb2d5a633dc1faef8fc6cd9f00710bf).
Code extracted from:

    https://github.com/Kitware/MetaIO.git

at commit 5e87f062ea796204b84fc3e5e9100cd3ead2e015 (master).
# By MetaIO Maintainers
* upstream-MetaIO:
  MetaIO 2021-09-28 (5e87f062)
@github-actions github-actions bot added area:ThirdParty Issues affecting the ThirdParty module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Sep 29, 2021
@bradking
Copy link
Member

FYI, #2659 was not done with the proper history shape. That's what caused the update here with the old script to fail. I manually built a fixed history shape to recover and switch to the new update script.

@bradking bradking changed the title Update MetaIO to 2019-11-18 (5005940b) MetaIO: Update to 2021-09-28 (5e87f062) Sep 29, 2021
Copy link
Member Author

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve my own PR, but it looks good.

@dzenanz
Copy link
Member Author

dzenanz commented Sep 29, 2021

And thank you, Brad!

@dzenanz dzenanz marked this pull request as ready for review September 29, 2021 19:53
@dzenanz dzenanz merged commit ed5c976 into InsightSoftwareConsortium:master Sep 30, 2021
@dzenanz dzenanz deleted the updateMetaIO branch September 30, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ThirdParty Issues affecting the ThirdParty module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants