Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix PythonVerifyGetOutputAPIConsistency test on Windows #3308

Merged
merged 1 commit into from Mar 17, 2022

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Mar 17, 2022

#3156 introduced a Python mechanism for loading object factory overrides alongside modules at load time. load_factories is an implementation detail and may not be suitable to be called directly.

Issue #3261 exhibits an instance of this where a few templates such as _Num_base are not loaded correctly into the itk namespace when load_factories is called by the client program before other modules are loaded. Removing the load_factories() call and relying on force_load() to instead load in both modules and factories results in successful namespace population.

Resolves #3261.

PR Checklist

  • Added test (or behavior not changed)

Refer to the ITK Software Guide for
further development details if necessary.

@tbirdso tbirdso requested review from thewtex and dzenanz March 17, 2022 13:27
@tbirdso
Copy link
Contributor Author

tbirdso commented Mar 17, 2022

Note that this will address one of three test failures we are seeing in the ITK main branch, with the other two unrelated to factory changes: CDash

@github-actions github-actions bot added area:Python wrapping Python bindings for a class type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Mar 17, 2022
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the CDash / CI attention @tbirdso !!

@tbirdso
Copy link
Contributor Author

tbirdso commented Mar 17, 2022

Checking ITK.Linux and ITK.Windows CI status shows that each check completed successfully but failed to POST results to Github due to "Internal Server Error". Perhaps more Github service issues today?

As all checks have passed I am moving forward with the merge.

@tbirdso tbirdso merged commit 9208559 into InsightSoftwareConsortium:master Mar 17, 2022
@PranjalSahu
Copy link
Contributor

Two checks failing on windows python for mesh serialization and pointset serialization.
Working on it.

@tbirdso
Copy link
Contributor Author

tbirdso commented Mar 17, 2022

@PranjalSahu I've also glanced through the serialization failures, they are due to inconsistencies in how we wrap VectorContainer across platforms and not directly due to any serialization issues. I've opened #3310 for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Python wrapping Python bindings for a class type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PythonVerifyGetOutputAPIConsistency failing on Windows
4 participants