Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Add template to TransformPhysicalPointToContinuousIndex in tests #4005

Conversation

N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Apr 9, 2023

Added missing template keywords to TransformPhysicalPointToContinuousIndex calls in Nonunit/Review tests.

Addressed compile errors from Ubuntu-22.04-gcc11.2-TBB-Debug saying:

error: expected primary-expression before '>' token

These compile errors were introduced by pull request #4000 commit 7cda5ba
"COMP: Fix TransformPhysicalPointToContinuousIndex nodiscard warnings"

Added missing `template` keywords to TransformPhysicalPointToContinuousIndex
calls in Nonunit/Review tests.

Addressed compile errors from Ubuntu-22.04-gcc11.2-TBB-Debug saying:

> error: expected primary-expression before '>' token

These compile errors were introduced by pull request InsightSoftwareConsortium#4000
commit 7cda5ba
"COMP: Fix TransformPhysicalPointToContinuousIndex `nodiscard` warnings"
@github-actions github-actions bot added type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Apr 9, 2023
@N-Dekker
Copy link
Contributor Author

@dzenanz Thanks for your approval. I think this PR is ready 😃

@dzenanz dzenanz merged commit 1f8c0f8 into InsightSoftwareConsortium:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants